Migrationg of `LintDiagnostic` - part 7 by GuillaumeGomez · Pull Request #153401 · rust-lang/rust

GuillaumeGomez · 2026-03-04T13:13:49Z

This PR removes the LintDiagnostic trait and proc-macro. \o/

rustbot · 2026-03-04T13:13:55Z

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @tshepang

Some changes occurred in exhaustiveness checking

cc @Nadrieril

rustc_macros::diagnostics was changed

cc @davidtwco, @TaKO8Ki, @JonathanBrouwer

GuillaumeGomez · 2026-03-04T13:14:44Z

@bors try @rust-timer queue

Migrationg of `LintDiagnostic` - part 7

src/doc/rustc-dev-guide/src/diagnostics/diagnostic-structs.md

GuillaumeGomez · 2026-03-04T13:24:03Z

@bors try-

@bors try @rust-timer queue

rust-bors · 2026-03-04T13:24:05Z

Unknown command "try-". Run @bors help to see available commands.

Migrationg of `LintDiagnostic` - part 7

JonathanBrouwer · 2026-03-04T13:39:08Z

@bors r+ rollup

rust-bors · 2026-03-04T13:39:12Z

📌 Commit 7b76829 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…athanBrouwer Migrationg of `LintDiagnostic` - part 7 Part of rust-lang#153099. This PR removes the `LintDiagnostic` trait and proc-macro. \o/ r? @JonathanBrouwer

JonathanBrouwer · 2026-03-04T14:04:48Z

@bors r-
r=me with green ci

rust-bors · 2026-03-04T15:35:04Z

☀️ Try build successful (CI)
Build commit: 22211ef (22211eff4f008ed0dee7818a863947ea4ee29b72, parent: b90dc1e597db0bbc0cab0eccb39747b1a9d7e607)

GuillaumeGomez · 2026-03-04T16:02:22Z

@bors r=JonathanBrouwer rollup

rust-bors · 2026-03-04T16:02:26Z

📌 Commit e805d8c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…athanBrouwer Migrationg of `LintDiagnostic` - part 7 Part of rust-lang#153099. This PR removes the `LintDiagnostic` trait and proc-macro. \o/ r? @JonathanBrouwer

rust-timer · 2026-03-04T16:15:11Z

Finished benchmarking commit (22211ef): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.3%, secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.2%	[6.2%, 6.2%]	1
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-4.2%	[-7.3%, -2.2%]	3
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Cycles

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[1.7%, 4.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.576s -> 479.993s (0.09%)
Artifact size: 397.00 MiB -> 394.95 MiB (-0.52%)

JonathanBrouwer · 2026-03-04T16:18:57Z

@bors rollup=always

Rollup of 9 pull requests Successful merges: - #152164 (Lint unused features) - #152801 (Refactor WriteBackendMethods a bit) - #153317 (Abort after `representability` errors) - #153361 (enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments) - #153402 (miri subtree update) - #153276 (Remove `cycle_fatal` query modifier) - #153396 (use `minicore` in some `run-make` tests) - #153401 (Migrationg of `LintDiagnostic` - part 7) - #153406 (Remove a ping for myself)

…uwer Rollup of 12 pull requests Successful merges: - #153402 (miri subtree update) - #152164 (Lint unused features) - #152801 (Refactor WriteBackendMethods a bit) - #153196 (Update path separators to be available in const context) - #153204 (Add `#[must_use]` attribute to `HashMap` and `HashSet` constructors) - #153317 (Abort after `representability` errors) - #153276 (Remove `cycle_fatal` query modifier) - #153300 (Tweak some of our internal `#[rustc_*]` TEST attributes) - #153396 (use `minicore` in some `run-make` tests) - #153401 (Migrationg of `LintDiagnostic` - part 7) - #153406 (Remove a ping for myself) - #153414 (Rename translation -> formatting)

@JonathanBrouwer

Rollup merge of #153401 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer Migrationg of `LintDiagnostic` - part 7 Part of #153099. This PR removes the `LintDiagnostic` trait and proc-macro. \o/ r? @JonathanBrouwer

…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#153402 (miri subtree update) - rust-lang/rust#152164 (Lint unused features) - rust-lang/rust#152801 (Refactor WriteBackendMethods a bit) - rust-lang/rust#153196 (Update path separators to be available in const context) - rust-lang/rust#153204 (Add `#[must_use]` attribute to `HashMap` and `HashSet` constructors) - rust-lang/rust#153317 (Abort after `representability` errors) - rust-lang/rust#153276 (Remove `cycle_fatal` query modifier) - rust-lang/rust#153300 (Tweak some of our internal `#[rustc_*]` TEST attributes) - rust-lang/rust#153396 (use `minicore` in some `run-make` tests) - rust-lang/rust#153401 (Migrationg of `LintDiagnostic` - part 7) - rust-lang/rust#153406 (Remove a ping for myself) - rust-lang/rust#153414 (Rename translation -> formatting)

GuillaumeGomez added 2 commits March 4, 2026 11:32

Migrate rustc_pattern_analysis lint to Diagnostic

ee855c0

Remove LintDiagnostic implementation on rustc_middle::Deprecated

c29a26e

rustbot assigned JonathanBrouwer Mar 4, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #153401 - GuillaumeGomez:migrate-diag, r=<try>

1834957

Migrationg of `LintDiagnostic` - part 7

cyrgani reviewed Mar 4, 2026

View reviewed changes

src/doc/rustc-dev-guide/src/diagnostics/diagnostic-structs.md Outdated Show resolved Hide resolved

GuillaumeGomez force-pushed the migrate-diag branch from aee21ab to 7b76829 Compare March 4, 2026 13:21

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #153401 - GuillaumeGomez:migrate-diag, r=<try>

22211ef

Migrationg of `LintDiagnostic` - part 7

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2026

JonathanBrouwer mentioned this pull request Mar 4, 2026

Rollup of 7 pull requests #153404

Closed

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2026

GuillaumeGomez added 4 commits March 4, 2026 15:16

Remove unused LintDiagnostic trait

7ceb8ea

Remove LintDiagnostic derive proc-macro

828398e

Update rustc-dev-guide to remove mentions of LintDiagnostic

d9ca8c9

Remove mentions of LintDiagnostic

e805d8c

GuillaumeGomez force-pushed the migrate-diag branch from 7b76829 to e805d8c Compare March 4, 2026 14:16

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2026

GuillaumeGomez mentioned this pull request Mar 4, 2026

Rollup of 9 pull requests #153412

Closed

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2026

JonathanBrouwer mentioned this pull request Mar 4, 2026

Rollup of 12 pull requests #153416

Merged

rust-bors bot merged commit 1500680 into rust-lang:main Mar 5, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 5, 2026

GuillaumeGomez deleted the migrate-diag branch March 5, 2026 10:38

Uh oh!

Conversation

GuillaumeGomez commented Mar 4, 2026

Uh oh!

rustbot commented Mar 4, 2026

Uh oh!

GuillaumeGomez commented Mar 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

GuillaumeGomez commented Mar 4, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

rust-timer commented Mar 4, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants