-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
MGCA: fix type error handling for const array and tuple lowering logic #153345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // This test ensures proper diagnostics emission during HIR ty lowering | ||
| // See https://github.com/rust-lang/rust/issues/153254 | ||
|
|
||
| #![feature(min_generic_const_args)] | ||
| #![expect(incomplete_features)] | ||
|
|
||
| type const T0: _ = (); | ||
| //~^ ERROR: the placeholder `_` is not allowed within types on item signatures for constants [E0121] | ||
|
|
||
| type const T1 = [0]; | ||
| //~^ ERROR: missing type for `const` item | ||
|
|
||
| fn main() {} | ||
20 changes: 20 additions & 0 deletions
20
tests/ui/const-generics/mgca/syntactic-type-mismatch.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| error[E0121]: the placeholder `_` is not allowed within types on item signatures for constants | ||
| --> $DIR/syntactic-type-mismatch.rs:7:16 | ||
| | | ||
| LL | type const T0: _ = (); | ||
| | ^ not allowed in type signatures | ||
|
|
||
| error: missing type for `const` item | ||
| --> $DIR/syntactic-type-mismatch.rs:10:14 | ||
| | | ||
| LL | type const T1 = [0]; | ||
| | ^ | ||
| | | ||
| help: provide a type for the item | ||
| | | ||
| LL | type const T1: <type> = [0]; | ||
| | ++++++++ | ||
|
|
||
| error: aborting due to 2 previous errors | ||
|
|
||
| For more information about this error, try `rustc --explain E0121`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.