Remove TranslationError#153228
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Mar 1, 2026
Merged
Conversation
Collaborator
|
cc @Muscraft
cc @Muscraft
cc @davidtwco, @TaKO8Ki |
rustbot
added
A-translation
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
remove_translate_error
branch
from
d2aeb33 to
6e8d9c1
Compare
Member
sure! i'm pretty free now, except i have a flight in four hours, so, i'm not sure if i'll be able to review this tomorrow, but it's very likely i'll be able to do it the day after tomorrow, which is a more realistic timeframe in the meanwhile, feel free to create those PRs, i'll review them once i get home |
Contributor
Author
|
No hurry with reviewing, a delay of a few days for reviewing is perfectly normal :) |
lqd
approved these changes
Feb 28, 2026
8 tasks
Contributor
Author
|
@bors r=lqd rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2026
…uwer Rollup of 9 pull requests Successful merges: - #146989 (Inhibit all-absent-variant optimization for all enum reprs that inhibit layout optimization, not just repr(C).) - #151991 (std: sys: pal: uefi: os: Implement split_paths) - #152794 (Fix ICE in `try_to_raw_bytes` when array elements have mismatched) - #153052 (std random.rs: update link to RTEMS docs) - #153054 (docs: note env var influence on `temp_dir` and `env_clear` on Windows) - #153061 (cleanup `tests/ui/box`, part 2) - #153197 (style: Update doctests for `TryFrom<integer> for bool` and `From<bool> for float`) - #153210 (Fix ICE on empty file with -Zquery-dep-graph) - #153228 (Remove `TranslationError`)
rust-timer
added a commit
that referenced
this pull request
Mar 1, 2026
Rollup merge of #153228 - JonathanBrouwer:remove_translate_error, r=lqd Remove `TranslationError` This function is now infallible, since the diagnostic message and presence of variables is already parsed in the `msg!` or `derive(Diagnostic)` macro. In practice, the result of this function was just unwrapped everywhere anyways... r? @Kivooeo if you feel like reviewing diagnostics PRs again, I have a few more coming :) (Tho other people are also free to steal these PRs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is now infallible, since the diagnostic message and presence of variables is already parsed in the
msg!orderive(Diagnostic)macro.In practice, the result of this function was just unwrapped everywhere anyways...
r? @Kivooeo if you feel like reviewing diagnostics PRs again, I have a few more coming :)
(Tho other people are also free to steal these PRs)