Rollup of 6 pull requests#153226
Closed
JonathanBrouwer wants to merge 14 commits intorust-lang:mainfrom
Closed
Conversation
The old URL with `master` resulted in a 404 error - use `main` instead.
- Based on Windows implementation. Just removed support for quote escaping since that is not supported in UEFI. - Tested using OVMF on QEMU Signed-off-by: Ayush Singh <ayush@beagleboard.org>
- Add test for split_paths for UEFI target. - `;` is the path separator. Escaping is not supported. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
These doctests are attached to the `TryFrom` trait. Therefore, it is easier to understand to use the `try_from` method instead of the `try_into` method.
These doctests are attached to the `From` trait. Therefore, it is easier to understand to use the `from` method instead of the `into` method.
* docs: explicitly list env vars checked by temp_dir on Windows On Windows, temp_dir() internally calls GetTempPath2/GetTempPath which checks TMP, TEMP, USERPROFILE environment variables in order. This information was previously only available by following links to Microsoft docs. Making it explicit in Rust's own documentation improves discoverability. Addresses rust-lang#125439. * docs: note env var influence on temp_dir and env_clear on Windows On Windows, �nv::temp_dir() internally calls GetTempPath2/GetTempPath, which checks TMP, TEMP, and USERPROFILE in order. Document this lookup order directly in the emp_dir docs rather than requiring users to follow the link to Microsoft documentation. Also add a note on Command::env_clear explaining that clearing the environment affects the child process's emp_dir(), not the parent's. Closes rust-lang#125439. * docs: drop Windows env_clear temp_dir note
std: sys: pal: uefi: os: Implement split_paths - Tested using OVMF on QEMU @rustbot label +O-UEFI cc @nicholasbishop
Fix ICE in `try_to_raw_bytes` when array elements have mismatched close: rust-lang#152683 After rust-lang#152001, suffixed integer literals preserve their own type during const lowering, so `try_to_raw_bytes` could call `.to_u8()` on a scalar with size > 1, causing an ICE. Fix by using `try_to_bits(Size::from_bytes(1)).ok()` instead. r? BoxyUwU
std random.rs: update link to RTEMS docs The old URL with `master` resulted in a 404 error - use `main` instead.
…s, r=Mark-Simulacrum docs: note env var influence on `temp_dir` and `env_clear` on Windows On Windows, `env::temp_dir()` internally calls `GetTempPath2`/`GetTempPath`, which checks the `TMP`, `TEMP`, and `USERPROFILE` environment variables in order before falling back to the Windows directory. This lookup order was previously only discoverable by following links to Microsoft documentation. This PR documents the env var lookup order directly in `env::temp_dir` docs and notes `GetTempPath2`'s SYSTEM-identity behavior (`C:\Windows\SystemTemp`). Addresses rust-lang#125439.
… r=joboet style: Update doctests for `TryFrom<integer> for bool` and `From<bool> for float` These doctests are attached to the `TryFrom` trait and the `From` trait. Although `From<U> for T` implies `Into<T> for U` and `TryFrom<U> for T` implies `TryInto<T> for U`, I think it is easier to understand to use the `try_from`/`from` method directly instead of the `try_into`/`into` method.
…jdonszelmann,JonathanBrouwer Fix ICE on empty file with -Zquery-dep-graph added a guard in `DepGraph::register_dep_node_debug_str` so it early-returns when `self.data` is still `None`. this happens for the first few dep-nodes in an empty crate with `-Z query-dep-graph`, which caused the previous `unwrap()` panic. fixes rust-lang#153199
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
try_to_raw_byteswhen array elements have mismatched #152794 (Fix ICE intry_to_raw_byteswhen array elements have mismatched)temp_dirandenv_clearon Windows #153054 (docs: note env var influence ontemp_dirandenv_clearon Windows)TryFrom<integer> for boolandFrom<bool> for float#153197 (style: Update doctests forTryFrom<integer> for boolandFrom<bool> for float)r? @ghost
Create a similar rollup