std::net: clamp linger timeout value to prevent silent truncation.#153207
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 1, 2026
Merged
std::net: clamp linger timeout value to prevent silent truncation.#153207rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Duration::as_secs() returns u64 but l_linger field type is narrower, c_int on most unix platforms, c_ushort on cygwin and windows. clamping before the cast, consistent with how set_timeout handles this.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
joboet
approved these changes
Feb 28, 2026
Member
|
The implementation looks good to me, but I'll reassign this to libs-api to decide whether rounding down here is correct (as opposed to rounding the duration up and returning an error if the time is nor representable). r? libs-api |
rustbot
added
the
T-libs-api
Member
|
This is fine, the underlying syscall clamps the value down to the maximum supported value anyways. @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
Rollup of 5 pull requests Successful merges: - #152935 (c-variadic: error when we can't guarantee that the backend does the right thing) - #153207 (std::net: clamp linger timeout value to prevent silent truncation.) - #154592 (Fix `mismatched_lifetime_syntaxes` suggestions for hidden path lifetimes) - #154643 (fix pin docs) - #154648 (Clarify `ty::List`)
rust-timer
added a commit
that referenced
this pull request
Apr 1, 2026
Rollup merge of #153207 - devnexen:net_set_linger_fix, r=Amanieu std::net: clamp linger timeout value to prevent silent truncation. Duration::as_secs() returns u64 but l_linger field type is narrower, c_int on most unix platforms, c_ushort on cygwin and windows. clamping before the cast, consistent with how set_timeout handles this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duration::as_secs() returns u64 but l_linger field type is narrower, c_int on most unix platforms, c_ushort on cygwin and windows. clamping before the cast, consistent with how set_timeout handles this.