Skip to content

Remove redundant clone #153200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 2 commits into from
Feb 28, 2026
Merged

Remove redundant clone #153200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca3867b
Remove redundant clone
AbstractiveNord Feb 27, 2026
c97f2c3
Apply tidy suggest
AbstractiveNord Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions compiler/rustc_parse/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,9 @@ pub fn new_parser_from_file<'a>(
let msg = format!("couldn't read `{}`: {}", path.display(), e);
let mut err = psess.dcx().struct_fatal(msg);
if let Ok(contents) = std::fs::read(path)
&& let Err(utf8err) = String::from_utf8(contents.clone())
&& let Err(utf8err) = std::str::from_utf8(&contents)
{
utf8_error(
sm,
&path.display().to_string(),
sp,
&mut err,
utf8err.utf8_error(),
&contents,
);
utf8_error(sm, &path.display().to_string(), sp, &mut err, utf8err, &contents);
}
if let Some(sp) = sp {
err.span(sp);
Expand Down
Loading