disable the ptr_fragment_in_final test on s390x#153177
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 3, 2026
Merged
disable the ptr_fragment_in_final test on s390x#153177rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
on s390x 128bit types have a smaller alignment then on x86[^1]. This leads to the tests falling due to different errors emitted. As this affects the same infrastructure as rust-lang#149056 lets also for now disable the tests on s390x. [^1]: s390x ELF ABI Table 1.1, Page 12 https://github.com/IBM/s390x-abi
fneddy
force-pushed
the
s390x_fix_test_ptr_fragments_final
branch
from
34ff4e7 to
2e0fdc5
Compare
Collaborator
|
fmease
approved these changes
Mar 2, 2026
Member
There was a problem hiding this comment.
It's unfortunate that you have to disable the test entirely on s390x instead of just fragment_in_padding but I see that that would necessitate a separate compiletest revision just for s390x to be able to make the annotation //~ERROR: partial pointer in final value conditional which seems like overkill. Well.
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
…s_final, r=fmease disable the ptr_fragment_in_final test on s390x on s390x 128bit types have a smaller alignment then on x86[^1]. This leads to the tests falling due to different errors emitted. As this affects the same infrastructure as rust-lang#149056 [^2] lets also for now disable the tests on s390x. [^1]: s390x ELF ABI Table 1.1, Page 12 https://github.com/IBM/s390x-abi [^2]: rust-lang#149056 (comment)
This was referenced Mar 3, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
…uwer Rollup of 12 pull requests Successful merges: - #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions) - #153227 (Don’t report missing fields in struct exprs with syntax errors.) - #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with) - #152966 (Migrate 11 tests from tests/ui/issues to specific directories) - #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc) - #153034 (Remove unhelpful hint from trivial bound errors) - #153152 (Migration of LintDiagnostic - part 5) - #153177 (disable the ptr_fragment_in_final test on s390x) - #153221 (Add release notes for 1.94.0) - #153279 (feat: Provide an '.item_kind()' method on ItemEnum) - #153297 (Update the name of the Hermit operating system) - #153309 (Cleanup of c-variadic link test)
rust-timer
added a commit
that referenced
this pull request
Mar 3, 2026
Rollup merge of #153177 - fneddy:s390x_fix_test_ptr_fragments_final, r=fmease disable the ptr_fragment_in_final test on s390x on s390x 128bit types have a smaller alignment then on x86[^1]. This leads to the tests falling due to different errors emitted. As this affects the same infrastructure as #149056 [^2] lets also for now disable the tests on s390x. [^1]: s390x ELF ABI Table 1.1, Page 12 https://github.com/IBM/s390x-abi [^2]: #149056 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on s390x 128bit types have a smaller alignment then on x861. This leads to the tests falling due to different errors emitted.
As this affects the same infrastructure as #149056 2 lets also for now disable the tests on s390x.
Footnotes
s390x ELF ABI Table 1.1, Page 12 https://github.com/IBM/s390x-abi ↩
https://github.com/rust-lang/rust/pull/149056#issuecomment-3547543222 ↩