std: move getpid to sys::process#153130
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 1, 2026
Merged
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
O-hermit
32 tasks
lygstate
reviewed
Feb 27, 2026
| #[stable(feature = "unix_ppid", since = "1.27.0")] | ||
| pub fn parent_id() -> u32 { | ||
| crate::sys::os::getppid() | ||
| crate::sys::process::getppid() |
Contributor
There was a problem hiding this comment.
We can implement getppid on windows, don't know why we do not have it.
Member
|
r=me if you don't want to wait on Hermit target maintainers to respond |
mkroening
approved these changes
Mar 1, 2026
Contributor
There was a problem hiding this comment.
Thanks for cleaning this up.
This does not break any applications we test in our CI (hermit-os/kernel#2286), so I think this is worth a try. Should we notice any other applications breaking due to this in the future, we'll open a PR. :)
Member
Author
|
Thanks 😉 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2026
…uwer Rollup of 6 pull requests Successful merges: - #153130 (std: move `getpid` to `sys::process`) - #152549 (Revert "resolve: Downgrade `ambiguous_glob_imports` to warn-by-default") - #153231 (diags: Pass `DiagArgMap` instead of `FluentArgs` into `format_diag_message`) - #153246 (Fix compile error in std::fs impl on VEXos target) - #153255 (Recover feature lang_items for emscripten) - #153257 (update my mailmap)
rust-timer
added a commit
that referenced
this pull request
Mar 1, 2026
Rollup merge of #153130 - joboet:move_getpid_sys_process, r=Mark-Simulacrum std: move `getpid` to `sys::process` Part of #117276. Availability of process IDs is highly correlated with availability of processes, so moving the `getpid` implementations to `sys::process` makes a lot of sense (and removes quite some code duplication). The only notable change here is on Hermit, which doesn't have processes but does have `getpid`. But that [always returns 0](https://github.com/hermit-os/kernel/blob/ef27b798856b50d562a42c4ffd2edcb7493c5b5f/src/syscalls/tasks.rs#L21), so I doubt it is useful. If the change to a panic is problematic we could always copy the stub implementation and return zero ourselves (this also applies to the other single-process platforms). CC @stlankes @mkroening
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 4, 2026
std: refactor Xous startup code To facilitate rust-lang#117276 I'm moving all non-path-related code out of `sys::pal::os` (see also rust-lang#153130). This is particularly involved for Xous as `pal::os` also contains the `_start` entry function and the parameter block handling. This PR moves both out into the main `sys::pal` module and also simplifies the parameter block initialisation code slightly. CC @xobs
rust-timer
added a commit
that referenced
this pull request
Mar 4, 2026
Rollup merge of #153341 - joboet:xous_params, r=tgross35 std: refactor Xous startup code To facilitate #117276 I'm moving all non-path-related code out of `sys::pal::os` (see also #153130). This is particularly involved for Xous as `pal::os` also contains the `_start` entry function and the parameter block handling. This PR moves both out into the main `sys::pal` module and also simplifies the parameter block initialisation code slightly. CC @xobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #117276.
Availability of process IDs is highly correlated with availability of processes, so moving the
getpidimplementations tosys::processmakes a lot of sense (and removes quite some code duplication). The only notable change here is on Hermit, which doesn't have processes but does havegetpid. But that always returns 0, so I doubt it is useful. If the change to a panic is problematic we could always copy the stub implementation and return zero ourselves (this also applies to the other single-process platforms).CC @stlankes @mkroening