Skip to content

interpret: avoid dummy spans in the stacktrace#153089

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:no-dummys
Feb 26, 2026
Merged

interpret: avoid dummy spans in the stacktrace#153089
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:no-dummys

Conversation

@RalfJung
Copy link
Member

This should fix rust-lang/miri#4871

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2026

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 25, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2026

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, mir
  • compiler, mir expanded to 68 candidates
  • Random selection from 14 candidates

Copy link
Member

@Kivooeo Kivooeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with ci green

View changes since this review

@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
REPOSITORY                                   TAG       IMAGE ID       CREATED       SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    b72a662c47e3   3 weeks ago   790MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:57ef9cc45f72cc4258ee1baa8243bc3cd55c0a0e570b6768c37346247be35f0d
deleted: sha256:b72a662c47e31df2e7bf59368b2b83be239f02a1baa721393717711a1a719df9
deleted: sha256:3e13ccd80f19769f39008cfc6549938e1ea4905f47b028c1df2dd6085191386c
deleted: sha256:842807995a512b2c5a9b241a3aecdbe79af6b0642d96fa5460cfcf0c9d8be295
deleted: sha256:0f9074b9f46f4570eb7cb4b65fcb3c3d909f9b1d14ca66b30508117b6deda303
deleted: sha256:2ca99cb9251d19157c56b5d91c8961bb4b35196a5ca9b4ffdccbf24abbfe2a5f

@Kivooeo Kivooeo closed this Feb 25, 2026
@Kivooeo Kivooeo reopened this Feb 25, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2026
@Kivooeo
Copy link
Member

Kivooeo commented Feb 25, 2026

Some network issues

@RalfJung
Copy link
Member Author

(I had already restarted CI.)

@RalfJung RalfJung closed this Feb 25, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2026
@RalfJung RalfJung reopened this Feb 25, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2026
@RalfJung
Copy link
Member Author

@bors r=Kivooeo

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 25, 2026

📌 Commit 82e5ed6 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 26, 2026
Rollup of 13 pull requests

Successful merges:

 - #148146 (CI: use alternative disks if available)
 - #151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
 - #153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
 - #153075 (mGCA: Lower negated literals directly and reject non-integer negations)
 - #153078 (Remove `QuerySystemFns`)
 - #153089 (interpret: avoid dummy spans in the stacktrace)
 - #153111 (Refactor url_parts to return is_absolute instead of out param)
 - #149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
 - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
 - #153063 (`is_ty_must_use`: do not require a `span` argument)
 - #153071 (Update books)
 - #153092 (Remove redundant self usages)
 - #153094 (Simplify `AppendOnlyVec` iterators)

Failed merges:

 - #153091 (Migration of `LintDiagnostic` - part 4)
@rust-bors rust-bors bot merged commit ec78ad8 into rust-lang:main Feb 26, 2026
25 of 55 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 26, 2026
rust-timer added a commit that referenced this pull request Feb 26, 2026
Rollup merge of #153089 - RalfJung:no-dummys, r=Kivooeo

interpret: avoid dummy spans in the stacktrace

This should fix rust-lang/miri#4871
@JonathanBrouwer
Copy link
Contributor

@rust-timer build 0fb636b

@rust-timer

This comment has been minimized.

RalfJung pushed a commit to RalfJung/miri that referenced this pull request Feb 26, 2026
Rollup of 13 pull requests

Successful merges:

 - rust-lang/rust#148146 (CI: use alternative disks if available)
 - rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
 - rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
 - rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations)
 - rust-lang/rust#153078 (Remove `QuerySystemFns`)
 - rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace)
 - rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param)
 - rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
 - rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
 - rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument)
 - rust-lang/rust#153071 (Update books)
 - rust-lang/rust#153092 (Remove redundant self usages)
 - rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators)

Failed merges:

 - rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0fb636b): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -5.8%, secondary 8.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
8.1% [7.9%, 8.2%] 2
Improvements ✅
(primary)
-5.8% [-5.8%, -5.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -5.8% [-5.8%, -5.8%] 1

Cycles

Results (secondary -5.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.4% [-5.4%, -5.4%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 492.161s -> 481.873s (-2.09%)
Artifact size: 395.78 MiB -> 397.80 MiB (0.51%)

github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Mar 2, 2026
Rollup of 13 pull requests

Successful merges:

 - rust-lang/rust#148146 (CI: use alternative disks if available)
 - rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
 - rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
 - rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations)
 - rust-lang/rust#153078 (Remove `QuerySystemFns`)
 - rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace)
 - rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param)
 - rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
 - rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
 - rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument)
 - rust-lang/rust#153071 (Update books)
 - rust-lang/rust#153092 (Remove redundant self usages)
 - rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators)

Failed merges:

 - rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panics with -Zmiri-report-progress when MIR basic blocks have no source location

7 participants