tests/ui/union: add annotations for reference rules#152826
tests/ui/union: add annotations for reference rules#152826DanielEScherzer wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
|
r? @ehuss |
|
wondering like what's the point in adding references in ui tests? |
|
To make it easier to confirm which rules are tested (I guess - I just found this as a place that I can help out, I'm not sure if that is the reasoning behind the initial addition of the tracking) |
wesleywiser
removed
the
T-compiler
|
@rustbot label +A-docs |
rustbot
added
the
A-docs
This comment was marked as outdated.
This comment was marked as outdated.
|
For reference: rust-lang/compiler-team#783 r? spec |
This comment was marked as outdated.
This comment was marked as outdated.
|
Trying again: r? spec |
| //@ run-pass | ||
| //@ reference: items.union.common-storage | ||
| //@ reference: items.union.fields.read | ||
| //@ reference: type.union.constraint |
There was a problem hiding this comment.
In what sense is this file testing type.union.constraint?
| @@ -1,4 +1,8 @@ | |||
| //@ run-pass | |||
| //@ reference: items.union.pattern | |||
There was a problem hiding this comment.
| //@ reference: items.union.pattern |
The cite of the parent rule should be dropped; the child rules are cited and the tooling flags this.
| @@ -1,3 +1,4 @@ | |||
| //@ reference: items.union.init.intro | |||
There was a problem hiding this comment.
Thoughts on items.union.pattern.one-field, patterns.struct.constraint-union, and expr.struct.field.union-constraint?
| //@ reference: safety.unsafe-union-access | ||
| //@ reference: type.union.safety |
There was a problem hiding this comment.
Thoughts on items.union.fields.write-safety and items.union.pattern.safety?
| //@ reference: items.union.pattern.intro | ||
| //@ reference: items.union.pattern.safety | ||
| //@ reference: items.union.pattern.subpattern |
There was a problem hiding this comment.
Thoughts on patterns.struct.refutable?
| //@ reference: items.union.field-restrictions | ||
| //@ reference: items.union.field-copy | ||
| //@ reference: items.union.field-references | ||
| //@ reference: items.union.field-manually-drop | ||
| //@ reference: items.union.field-tuple | ||
| //@ reference: type.union.constraint |
There was a problem hiding this comment.
Thoughts on items.union.drop?
| @@ -1,4 +1,5 @@ | |||
| //@ run-pass | |||
| //@ reference: items.union.drop | |||
There was a problem hiding this comment.
Thoughts on destructors.manually-suppressing?
| //@ reference: items.union.pattern | ||
| //@ reference: items.union.pattern.intro | ||
| //@ reference: items.union.pattern.safety | ||
| //@ reference: items.union.pattern.subpattern |
There was a problem hiding this comment.
items.union.pattern.subpattern has been deleted in rust-lang/reference#2303.
8 participants
r? lang-docs