Skip to content

Comments

Exchange js_lint message between bless and non-bless#152610

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Shunpoco:fix-js-lint-bless-message
Feb 15, 2026
Merged

Exchange js_lint message between bless and non-bless#152610
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Shunpoco:fix-js-lint-bless-message

Conversation

@Shunpoco
Copy link
Contributor

The message applying suggestions should be emitted when bless is enabled.

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 14, 2026
@Shunpoco Shunpoco marked this pull request as ready for review February 14, 2026 10:45
@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2026

tidy extra checks were modified.

cc @lolbinarycat

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2026

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789

@lolbinarycat
Copy link
Contributor

i think this bug predates my rewrite and i just preserved the existing behavior without thinking about it too hard, definitely something that should be fixed.

@clubby789
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 14, 2026

📌 Commit 98975ff has been approved by clubby789

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 15, 2026
Rollup of 9 pull requests

Successful merges:

 - #150424 (diagnostics: add note when param-env shadows global impl)
 - #152132 (implement `carryless_mul`)
 - #152508 (Improve write! and writeln! error when called without destination)
 - #152534 (Test(lib/win/net): Skip UDS tests when under Win7)
 - #152578 (ci: Lock cross toolchain version and update docs)
 - #152188 (Include `library/stdarch` for `CURRENT_RUSTC_VERSION` updates)
 - #152402 (Add regression test for #141738)
 - #152472 (unwind/wasm: fix compile error by wrapping wasm_throw in unsafe block)
 - #152610 (Exchange js_lint message between bless and non-bless)
@rust-bors rust-bors bot merged commit 12755aa into rust-lang:main Feb 15, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Feb 15, 2026
Rollup merge of #152610 - Shunpoco:fix-js-lint-bless-message, r=clubby789

Exchange js_lint message between bless and non-bless

The message `applying suggestions` should be emitted when bless is enabled.
@rustbot rustbot added this to the 1.95.0 milestone Feb 15, 2026
github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request Feb 16, 2026
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#150424 (diagnostics: add note when param-env shadows global impl)
 - rust-lang/rust#152132 (implement `carryless_mul`)
 - rust-lang/rust#152508 (Improve write! and writeln! error when called without destination)
 - rust-lang/rust#152534 (Test(lib/win/net): Skip UDS tests when under Win7)
 - rust-lang/rust#152578 (ci: Lock cross toolchain version and update docs)
 - rust-lang/rust#152188 (Include `library/stdarch` for `CURRENT_RUSTC_VERSION` updates)
 - rust-lang/rust#152402 (Add regression test for rust-lang/rust#141738)
 - rust-lang/rust#152472 (unwind/wasm: fix compile error by wrapping wasm_throw in unsafe block)
 - rust-lang/rust#152610 (Exchange js_lint message between bless and non-bless)
@Shunpoco Shunpoco deleted the fix-js-lint-bless-message branch February 17, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants