std: use OnceLock for Xous environment variables#152535
Open
joboet wants to merge 1 commit intorust-lang:mainfrom
Open
std: use OnceLock for Xous environment variables#152535joboet wants to merge 1 commit intorust-lang:mainfrom
OnceLock for Xous environment variables#152535joboet wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
This seems good to me. I believe the pointer shenanigans were from before we started collecting the arguments in an iterator, so it's good to get rid of it since it's not required. |
Member
Author
|
@rustbot reroll |
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
xous_env_once_lock
branch
from
f9a1b3b to
6f980d4
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need for exposed-provenance-shenanigans here...
CC @xobs