Uplift Predicate::allow_normalization to rustc_type_ir#152396
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 10, 2026
Merged
Uplift Predicate::allow_normalization to rustc_type_ir#152396rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Predicate::allow_normalization to rustc_type_ir#152396rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Member
Author
|
Looks like GitHub is in an ourtrage 🤔 I'll re-trigger the CI tomorrow |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
lcnr
reviewed
Feb 9, 2026
| /// | ||
| /// Wf predicates must not be normalized, as normalization | ||
| /// can remove required bounds which would cause us to | ||
| /// unsoundly accept some programs. See #91068. |
Contributor
There was a problem hiding this comment.
iirc we don't move comments for duplicated methods, could look at a few other methods to check.
please keep the comment in rustc_middle
ShoyuVanilla
force-pushed
the
uplift-allow-normalize
branch
from
3f8e823 to
20f65fc
Compare
Member
Author
|
@bors r=lcnr rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 10, 2026
…e, r=lcnr Uplift `Predicate::allow_normalization` to `rustc_type_ir` Found this FIXME comment while fixing a bug in rust-analyzer 😄 cc rust-lang/rust-analyzer#21611 r? types
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
Rollup of 7 pull requests Successful merges: - #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 10, 2026
…e, r=lcnr Uplift `Predicate::allow_normalization` to `rustc_type_ir` Found this FIXME comment while fixing a bug in rust-analyzer 😄 cc rust-lang/rust-analyzer#21611 r? types
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 10, 2026
…e, r=lcnr Uplift `Predicate::allow_normalization` to `rustc_type_ir` Found this FIXME comment while fixing a bug in rust-analyzer 😄 cc rust-lang/rust-analyzer#21611 r? types
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 10, 2026
…e, r=lcnr Uplift `Predicate::allow_normalization` to `rustc_type_ir` Found this FIXME comment while fixing a bug in rust-analyzer 😄 cc rust-lang/rust-analyzer#21611 r? types
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152364 (Port a lot of attributes to the new parser) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - #152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152355 (Update documentation of rustc_macros) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`) - #152425 (Port #![test_runner] to the attribute parser)
Contributor
|
@bors r+ rollup |
Contributor
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
…uwer Rollup of 10 pull requests Successful merges: - #152364 (Port a lot of attributes to the new parser) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - #152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152355 (Update documentation of rustc_macros) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)
rust-timer
added a commit
that referenced
this pull request
Feb 10, 2026
Rollup merge of #152396 - ShoyuVanilla:uplift-allow-normalize, r=lcnr Uplift `Predicate::allow_normalization` to `rustc_type_ir` Found this FIXME comment while fixing a bug in rust-analyzer 😄 cc rust-lang/rust-analyzer#21611 r? types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this FIXME comment while fixing a bug in rust-analyzer 😄
cc rust-lang/rust-analyzer#21611
r? types