Conversation
|
rustbot has assigned @JonathanBrouwer. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Hi there, thanks for your contribution! Could you explain what bug this is fixing, and if possible, add a regression test? |
I think add this continue statement is reasonable, same as in |
|
This looks right to me, especially given the comment, but don't know the code and could also believe a |
| if alias_ty.span.desugaring_kind().is_some() { | ||
| // Skip `async` desugaring `impl Future`. | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Question: can a test demonstrate the diagnostics effect before/after this change? The change itself looks reasonable.
There was a problem hiding this comment.
I have try to,construct. But do not find the right way. it failed then.
|
@bors r+ rollup |
Rollup of 17 pull requests Successful merges: - #142415 (Add note when inherent impl for a alias type defined outside of the crate) - #142680 (Fix passing/returning structs with the 64-bit SPARC ABI) - #150768 (Don't compute FnAbi for LLVM intrinsics in backends) - #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes) - #151814 (layout: handle rigid aliases without params) - #151863 (Borrowck: simplify diagnostics for placeholders) - #152159 (Add note for `?Sized` params in int-ptr casts diag) - #152434 (Clarify names of `QueryVTable` functions for "executing" a query) - #152478 (Remove tm_factory field from CodegenContext) - #152498 (Partially revert "resolve: Update `NameBindingData::vis` in place") - #152316 (fix: add continue) - #152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter) - #152425 (Port #![test_runner] to the attribute parser) - #152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif) - #152485 (fix issue#152482) - #152495 (Clean up some subdiagnostics) - #152502 (Implement `BinaryHeap::from_raw_vec`)
Rollup merge of #152316 - cuiweixie:bugfix-continue, r=petrochenkov fix: add continue should be same in: https://github.com/rust-lang/rust/blob/d3ec6a351a027a71bdfbd36429288c1357ccdbea/compiler/rustc_trait_selection/src/error_reporting/infer/nice_region_error/static_impl_trait.rs#L156-L159
should be same in:
rust/compiler/rustc_trait_selection/src/error_reporting/infer/nice_region_error/static_impl_trait.rs
Lines 156 to 159 in d3ec6a3