-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
misc doc improvements #152206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
misc doc improvements #152206
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2a6b9e6
inline the binding
tshepang 193bc70
missing word
tshepang 5b68138
add trailing commas
tshepang 6bb8cc6
obsolete comment
tshepang 638d23c
E0570: improve text
tshepang 84741ed
add reading pauses in doc comment
tshepang 3be2843
make docs render better by separating intro from rest of paragraph
tshepang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| The requested ABI is unsupported by the current target. | ||
|
|
||
| The rust compiler maintains for each target a list of unsupported ABIs on | ||
| that target. If an ABI is present in such a list this usually means that the | ||
| The Rust compiler maintains a list of unsupported ABIs for each target. | ||
| If an ABI is present in such a list, this usually means that the | ||
| target / ABI combination is currently unsupported by llvm. | ||
|
|
||
| If necessary, you can circumvent this check using custom target specifications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused by changes like this one.
@tshepang I appreciate your interest in improving our texts (see also your patches elsewhere in the project), but do you think we really need to spend time on nits like these? Can we maybe set a lower bound under which your time (authoring) plus our time (reviewing) is not worth the effort?
just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have mentioned that it's better reviewed a commit at a time, since each commit message justifies the change