Suggest returning a reference for unsized place from a closure#152162
Open
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Open
Suggest returning a reference for unsized place from a closure#152162chenyukang wants to merge 1 commit intorust-lang:mainfrom
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use |
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
chenyukang
force-pushed
the
yukang-fix-152064-unsized-closure-return
branch
from
882fe19 to
cb75047
Compare
This comment has been minimized.
This comment has been minimized.
|
I haven't tested this, but from reading your patch, it looks like this will be very helpful to the next newbie after me. Thank you so much for picking this up! |
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
chenyukang
force-pushed
the
yukang-fix-152064-unsized-closure-return
branch
from
cb75047 to
b4469fc
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-152064-unsized-closure-return
branch
from
b4469fc to
d153f44
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-152064-unsized-closure-return
branch
from
d153f44 to
f34db2f
Compare
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 7, 2026
…ed-closure-return, r=petrochenkov Suggest returning a reference for unsized place from a closure Fixes rust-lang#152064 There are 3 similar note: `the size for values of type str cannot be known at compilation time` for different spans, maybe need more work to remove some of them. This PR only adds a suggestion for using a reference.
Contributor
rust-bors
bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#154952), which was unapproved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152064
There are 3 similar note:
the size for values of type str cannot be known at compilation timefor different spans, maybe need more work to remove some of them.
This PR only adds a suggestion for using a reference.