Suggest async block instead of async closure when possible#152042
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Mar 1, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
JohnTitor
reviewed
Feb 5, 2026
| && obligation.cause.span.contains(*arg_span) | ||
| { | ||
| err.span_suggestion_verbose( | ||
| arg_span.with_hi(arg_span.hi() + rustc_span::BytePos(1)), |
Member
There was a problem hiding this comment.
It's an edge-case but the suggestion would be broken if there's no whitespace, like:
takes_future(async||{
chenyukang
force-pushed
the
yukang-fix-140265-async-closure-suggestion
branch
from
ab0f461 to
1a4fcc1
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
r=me if you want |
Member
Author
|
@bors retry |
Contributor
|
❗ You can only retry pull requests that are approved and have a previously failed auto build. |
chenyukang
force-pushed
the
yukang-fix-140265-async-closure-suggestion
branch
from
1a4fcc1 to
37f4765
Compare
Member
Author
|
let me wait whether it's green from CI now. |
chenyukang
force-pushed
the
yukang-fix-140265-async-closure-suggestion
branch
from
37f4765 to
3736458
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=JohnTitor |
Contributor
rust-bors
bot
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2026
…-closure-suggestion, r=JohnTitor Suggest async block instead of async closure when possible Fixes rust-lang#140265 r? @estebank
This was referenced Mar 1, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2026
Rollup of 5 pull requests Successful merges: - #152042 (Suggest async block instead of async closure when possible) - #152949 (Introduce --ci flag in tidy) - #152655 (Disable debug_assert_not_in_new_nodes for multiple threads) - #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`) - #153229 (rustfmt: add test for field representing type builtin syntax)
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2026
Rollup of 5 pull requests Successful merges: - #152042 (Suggest async block instead of async closure when possible) - #152949 (Introduce --ci flag in tidy) - #152655 (Disable debug_assert_not_in_new_nodes for multiple threads) - #153209 (Clean up `QueryVTable::hash_result` into `hash_value_fn`) - #153229 (rustfmt: add test for field representing type builtin syntax)
rust-timer
added a commit
that referenced
this pull request
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140265
r? @estebank