Skip to content

Fix uninitialized UEFI globals in tests #151979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Feb 3, 2026
Merged

Fix uninitialized UEFI globals in tests #151979

rust-bors merged 1 commit into from
Feb 3, 2026
+19 −6

Conversation

@nicholasbishop
Copy link
Contributor

@nicholasbishop nicholasbishop commented Feb 2, 2026

Export globals via a doc(hidden) module. In test code, use the globals from realstd so that they are properly initialized.

CC @Ayush1325

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jhpratt
Copy link
Member

jhpratt commented Feb 2, 2026

Simple enough change. Would you like to wait for the co-maintainer or have this approved now? I'm fine either way.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nicholasbishop
Fix uninitialized UEFI globals in tests
59868c1 
Export globals via a `doc(hidden)` module. In test code, use the globals
from `realstd` so that they are properly initialized.
@jhpratt
Copy link
Member

jhpratt commented Feb 2, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 2, 2026

📌 Commit 59868c1 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 2, 2026
@jhpratt
Rollup merge of rust-lang#151979 - nicholasbishop:push-ssmqyutnpypo, …
2915174 
…r=jhpratt

Fix uninitialized UEFI globals in tests

Export globals via a `doc(hidden)` module. In test code, use the globals from `realstd` so that they are properly initialized.

CC @Ayush1325
@jhpratt jhpratt mentioned this pull request Feb 2, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #151984 - jhpratt:rollup-OHZj4tL, r=jhpratt
1626a9e 
Rollup of 5 pull requests

Successful merges:

 - #151825 (more float constants)
 - #151958 (Add codegen test for SLP vectorization)
 - #151974 (Update documentation for `Result::ok()`)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 2, 2026
@jhpratt
Rollup merge of rust-lang#151979 - nicholasbishop:push-ssmqyutnpypo, …
189445c 
…r=jhpratt

Fix uninitialized UEFI globals in tests

Export globals via a `doc(hidden)` module. In test code, use the globals from `realstd` so that they are properly initialized.

CC @Ayush1325
@jhpratt jhpratt mentioned this pull request Feb 2, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #151987 - jhpratt:rollup-CkK6vN9, r=jhpratt
6f59a55 
Rollup of 5 pull requests

Successful merges:

 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151825 (more float constants)
 - #151974 (Update documentation for `Result::ok()`)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151979 - nicholasbishop:push-ssmqyutnpypo, …
c785955 
…r=jhpratt

Fix uninitialized UEFI globals in tests

Export globals via a `doc(hidden)` module. In test code, use the globals from `realstd` so that they are properly initialized.

CC @Ayush1325
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 2, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #151997 - JonathanBrouwer:rollup-txk7tC8, r=JonathanBro…
6ad3d3d 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #150992 (link modifier `export-symbols`: export all global symbols from selected uptream c static libraries)
 - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive)
 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151172 (Use default field values in a few more cases)
 - #151825 (more float constants)
 - #151870 (regression test for alias-relate changes in lub)
 - #151902 (explain why we dont skip some of this work when there are field projections)
 - #151974 (Update documentation for `Result::ok()`)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
 - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151979 - nicholasbishop:push-ssmqyutnpypo, …
60133a3 
…r=jhpratt

Fix uninitialized UEFI globals in tests

Export globals via a `doc(hidden)` module. In test code, use the globals from `realstd` so that they are properly initialized.

CC @Ayush1325
This was referenced Feb 2, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #152006 - JonathanBrouwer:rollup-TXHXPNU, r=JonathanBro…
6c828e5 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports)
 - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive)
 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151172 (Use default field values in a few more cases)
 - #151825 (more float constants)
 - #151870 (regression test for alias-relate changes in lub)
 - #151872 (Add inline syntax for diagnostic messages)
 - #151902 (explain why we dont skip some of this work when there are field projections)
 - #151909 (Skip overlapping spans in argument error suggestions)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
 - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #152006 - JonathanBrouwer:rollup-TXHXPNU, r=JonathanBro…
fc8438a 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports)
 - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive)
 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151172 (Use default field values in a few more cases)
 - #151825 (more float constants)
 - #151870 (regression test for alias-relate changes in lub)
 - #151872 (Add inline syntax for diagnostic messages)
 - #151902 (explain why we dont skip some of this work when there are field projections)
 - #151909 (Skip overlapping spans in argument error suggestions)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
 - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
rust-bors bot pushed a commit that referenced this pull request Feb 3, 2026
@bors
Auto merge of #152006 - JonathanBrouwer:rollup-TXHXPNU, r=JonathanBro…
5ac8ece 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports)
 - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive)
 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151172 (Use default field values in a few more cases)
 - #151825 (more float constants)
 - #151870 (regression test for alias-relate changes in lub)
 - #151872 (Add inline syntax for diagnostic messages)
 - #151902 (explain why we dont skip some of this work when there are field projections)
 - #151909 (Skip overlapping spans in argument error suggestions)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
 - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
@rust-bors rust-bors bot merged commit 22b2913 into rust-lang:main Feb 3, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 3, 2026
rust-timer added a commit that referenced this pull request Feb 3, 2026
@rust-timer
Unrolled build for #151979
0bef0f3 
Rollup merge of #151979 - nicholasbishop:push-ssmqyutnpypo, r=jhpratt

Fix uninitialized UEFI globals in tests

Export globals via a `doc(hidden)` module. In test code, use the globals from `realstd` so that they are properly initialized.

CC @Ayush1325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ayush1325 Ayush1325 Ayush1325 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jhpratt jhpratt

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nicholasbishop @rustbot @jhpratt @rust-log-analyzer @Ayush1325