Skip to content

Fix ICE when projection error reporting sees opaque alias terms #151923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Feb 2, 2026
Merged

Fix ICE when projection error reporting sees opaque alias terms #151923

rust-bors merged 1 commit into from
Feb 2, 2026
+21 −0

Conversation

@TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Jan 31, 2026 •
edited by rustbot
Loading

Fixes #151331

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 31, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@JayanAXHF JayanAXHF added the I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ label Jan 31, 2026
@fmease fmease removed the I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ label Jan 31, 2026
Kivooeo
Kivooeo approved these changes Jan 31, 2026
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fix does indeed looks correct to me, but id still like to check in with someone who better understand this code, @fmease maybe?

View changes since this review

@jieyouxu jieyouxu assigned Kivooeo and unassigned jieyouxu Feb 1, 2026
fmease
fmease approved these changes Feb 1, 2026
View reviewed changes
Copy link
Member

@fmease fmease left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! @bors r=Kivooeo,fmease rollup

View changes since this review

compiler/rustc_trait_selection/src/error_reporting/traits/fulfillment_errors.rs
Copy link
Member

@fmease fmease Feb 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct; the existing logic in report_projection_error "can only deal with" / "is mostly geared to handle" projection mismatches, not arbitrary aliases mismatches.

Still, we currently map unsolved NormalizesTo and AliasRelate goals to FulfillmentErrorCode::Project (in fn fulfillment_error_for_no_solution).

Long term, we should probably rename+generalize FulfillmentErrorCode::Project to account for all AliasTerms and extend downstream code to handle all alias terms better (e.g., give more suggestions).

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 1, 2026

📌 Commit c8ce140 has been approved by Kivooeo,fmease

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 1, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151923 - TaKO8Ki:issue-151331-opaque-alias-…
0e29291 
…relate, r=Kivooeo,fmease

Fix ICE when projection error reporting sees opaque alias terms

Fixes rust-lang#151331
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 1, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 1, 2026
@bors
Auto merge of #151965 - JonathanBrouwer:rollup-mn7HX4P, r=JonathanBro…
b0e6e11 
…uwer

Rollup of 10 pull requests

Successful merges:

 - #150428 (UnixStream/UnixListener on Windows )
 - #147400 (TryFrom<integer> for bool)
 - #150993 (std: sys: uefi: os: Implement join_paths)
 - #151483 (Add regression test for issue #138225)
 - #151568 (Update hexagon target linker configurations)
 - #151725 (Fix outdated Debian Ports ISO reference)
 - #151895 (Move UI tests batch)
 - #151923 (Fix ICE when projection error reporting sees opaque alias terms)
 - #151947 (Include assoc const projections in CFI trait object)
 - #151948 (Handle unbalanced delimiters gracefully in make_attr_token_stream)
@Zalathar Zalathar mentioned this pull request Feb 1, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #151971 - Zalathar:rollup-KwKpKLY, r=Zalathar
32b9023 
Rollup of 11 pull requests

Successful merges:

 - #151756 (Avoid miri error in `slice::sort` under Stacked Borrows)
 - #147400 (TryFrom<integer> for bool)
 - #150993 (std: sys: uefi: os: Implement join_paths)
 - #151483 (Add regression test for issue #138225)
 - #151568 (Update hexagon target linker configurations)
 - #151725 (Fix outdated Debian Ports ISO reference)
 - #151895 (Move UI tests batch)
 - #151923 (Fix ICE when projection error reporting sees opaque alias terms)
 - #151947 (Include assoc const projections in CFI trait object)
 - #151948 (Handle unbalanced delimiters gracefully in make_attr_token_stream)
 - #151963 (Add regression test for negative literal in a range of unsigned type)
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #151971 - Zalathar:rollup-KwKpKLY, r=Zalathar
a60d12c 
Rollup of 11 pull requests

Successful merges:

 - #151756 (Avoid miri error in `slice::sort` under Stacked Borrows)
 - #147400 (TryFrom<integer> for bool)
 - #150993 (std: sys: uefi: os: Implement join_paths)
 - #151483 (Add regression test for issue #138225)
 - #151568 (Update hexagon target linker configurations)
 - #151725 (Fix outdated Debian Ports ISO reference)
 - #151895 (Move UI tests batch)
 - #151923 (Fix ICE when projection error reporting sees opaque alias terms)
 - #151947 (Include assoc const projections in CFI trait object)
 - #151948 (Handle unbalanced delimiters gracefully in make_attr_token_stream)
 - #151963 (Add regression test for negative literal in a range of unsigned type)
@rust-bors rust-bors bot merged commit be3bf82 into rust-lang:main Feb 2, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 2, 2026
rust-timer added a commit that referenced this pull request Feb 2, 2026
@rust-timer
Unrolled build for #151923
4237666 
Rollup merge of #151923 - TaKO8Ki:issue-151331-opaque-alias-relate, r=Kivooeo,fmease

Fix ICE when projection error reporting sees opaque alias terms

Fixes #151331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease approved these changes

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

[ICE]: expected a projection

6 participants

@TaKO8Ki @rustbot @fmease @Kivooeo @jieyouxu @JayanAXHF