Disable append-elements.rs test with debug assertions #151859
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IR is a bit different (in particular wrt naming) if debug-assertions-std is enabled. Peculiarly, the issue goes away if overflow-check-std is also enabled, which is why CI did not catch this.
rustbot
added
S-waiting-on-review
Member
|
Fine as a quick fix I guess, though if value naming is still to brittle it might break again in the future. Should be fine to rollup since it only disables the test in more cases. @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 30, 2026
…uwer Rollup of 4 pull requests Successful merges: - #151376 (Fix performance issue in liveness checking) - #151851 (Remove redundant `IntoQueryParam` calls from query plumbing) - #151854 (Show break type expectation cause for let-else) - #151859 (Disable append-elements.rs test with debug assertions)
rust-timer
added a commit
that referenced
this pull request
Jan 30, 2026
Rollup merge of #151859 - nikic:append-elements-test, r=the8472 Disable append-elements.rs test with debug assertions The IR is a bit different (in particular wrt naming) if debug-assertions-std is enabled. Peculiarly, the issue goes away if overflow-check-std is also enabled, which is why CI did not catch this. r? @the8472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IR is a bit different (in particular wrt naming) if debug-assertions-std is enabled. Peculiarly, the issue goes away if overflow-check-std is also enabled, which is why CI did not catch this.
r? @the8472