Skip to content

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Jan 29, 2026

Tracking issue: #131229

Uses #151827

r? jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2026

⚠️ #[rustc_allow_const_fn_unstable] needs careful audit to avoid accidentally exposing unstable
implementation details on stable.

cc @rust-lang/wg-const-eval

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to constck

cc @fee1-dead

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 29, 2026
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jan 29, 2026

Yup, thanks for the contribution but let's for now @rustbot blocked on #151827

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@fmease fmease added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jan 30, 2026
@JonathanBrouwer
Copy link
Contributor

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 30, 2026

📌 Commit 72338fa has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 30, 2026
…athanBrouwer

Port `rustc_layout` to attribute parser

Tracking issue: rust-lang#131229

Uses rust-lang#151827

r? jdonszelmann
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 30, 2026
…athanBrouwer

Port `rustc_layout` to attribute parser

Tracking issue: rust-lang#131229

Uses rust-lang#151827

r? jdonszelmann
rust-bors bot pushed a commit that referenced this pull request Jan 30, 2026
…uwer

Rollup of 3 pull requests

Successful merges:

 - #151736 (Make some load-from-disk function pointers optional in query vtables)
 - #151831 (Port `rustc_layout` to attribute parser)
 - #151856 (Fix flakyness issue with `tests/rustdoc-gui/globals.goml` test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants