Rollup of 8 pull requests #151803
Closed
Rollup of 8 pull requests #151803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the search results
…precated item marker"
Signed-off-by: Antonio Souza <[email protected]>
When an async closure captures a variable by move but is constrained to `AsyncFn` or `AsyncFnMut`, the error message now explains that the closure kind is the issue and points to the trait bound, similar to the existing diagnostic for `Fn`/`FnMut` closures.
…thar Tidy: detect ui tests subdirectory changes so `tests/ui/README.md` stays in sync close: rust-lang#150399 There's an issue where `tests/ui/README.md` isn't updated whenever the ui subdirectory changes. I've added subdirectory change detection to tidy ~~added a new mention to `triage.toml` to notify `tests/ui/README.md` to also be updated~~. r? @Urgau
…iagnostic-v2, r=lcnr
Improve move error diagnostic for `AsyncFn` closures
When an async closure captures a variable by move but is constrained to `AsyncFn` or `AsyncFnMut`, the error message now explains that the closure kind is the issue and points to the trait bound, similar to the existing diagnostic for `Fn`/`FnMut` closures.
**Before:**
```
error[E0507]: cannot move out of `foos` which is behind a shared reference
--> src/lib.rs:12:20
|
11 | async fn foo(foos: &mut [&mut Foo]) -> Result<(), ()> {
| ---- move occurs because `foos` has type...
12 | in_transaction(async || -> Result<(), ()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ `foos` is moved here
13 | for foo in foos {
| ---- variable moved due to use in coroutine
```
**After:**
```
error[E0507]: cannot move out of `y`, a captured variable in an `AsyncFn` closure
--> src/lib.rs:9:10
|
LL | let y = vec![format!("World")];
| - captured outer variable
LL | call(async || {
| ^^^^^^^^ captured by this `AsyncFn` closure
...
help: `AsyncFn` and `AsyncFnMut` closures require captured values to be able
to be consumed multiple times, but `AsyncFnOnce` closures may consume
them only once
--> src/lib.rs:5:27
|
LL | fn call<F>(_: F) where F: AsyncFn() {}
| ^^^^^^^^^
```
Fixes rust-lang#150174
…arn, r=nnethercote,saethlin Fix -Zmir-enable-passes to detect unregistered enum names in declare_passes macro related: rust-lang#150910 I fixed declare_passes macro to detect unregistered enum names ### UI Results +nightly --> before: no warnings +stage1 --> after: detect SimplifyCfg as an unknown pass <img width="591" height="199" alt="スクリーンショット 2026-01-24 23 53 41" src="https://github.com/user-attachments/assets/ddabaa58-b4c6-4e80-a3c9-f40d866db273" />
Make `QueryDispatcher::Qcx` an associated type There's no reason to think that a query dispatcher/vtable would support multiple query-context types, and this simplifies some generic signature boilerplate. --- - This is the planned change that was mentioned in rust-lang#151777 (comment). r? nnethercote
…cated-search, r=lolbinarycat [rustdoc] Add a marker to tell users that there are hidden (deprecated) items in the search results Someone on mastodon rightfully pointed out that having a visual indication that some search results were hidden would be a good idea if the "hide deprecated items" setting is enabled. In particular if no results are displayed. It looks like this: <img width="861" height="228" alt="Screenshot From 2026-01-24 00-26-33" src="https://github.com/user-attachments/assets/93aeef11-a550-47dc-9c78-219ea4fd822c" /> r? @lolbinarycat
…=GuillaumeGomez Fix contrast ratio for `Since` element in rustodoc dark theme Changed `--right-side-color` from `#808080` to `#ababab` in the dark theme. <img width="742" height="784" alt="Screenshot 2026-01-25 at 8 04 29 PM" src="https://github.com/user-attachments/assets/38c5f0b9-2034-429f-87db-8a0ed8209b5d" /> Verified visually in dark theme, it's now more readable: <img width="174" height="96" alt="Screenshot 2026-01-25 at 8 41 02 PM" src="https://github.com/user-attachments/assets/d0c30409-4374-48c4-ae9c-a0aec48e8957" /> Part of rust-lang#59845 Fixes rust-lang#151422
…illaumeGomez Update `askama` to `0.15.3` Some bugfixes. r? ghost
…ion, r=JonathanBrouwer Subscribe myself to translation diagnostics
rustbot
added
A-CI
rustbot
added
T-compiler
Member
Author
|
Rollup of everything. @bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 1b762e2 with merge 8d64c72... Workflow: https://github.com/rust-lang/rust/actions/runs/21465009622 |
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
Rollup of 8 pull requests Successful merges: - #150474 (Tidy: detect ui tests subdirectory changes so `tests/ui/README.md` stays in sync) - #150572 (Improve move error diagnostic for `AsyncFn` closures) - #151596 (Fix -Zmir-enable-passes to detect unregistered enum names in declare_passes macro) - #151802 (Make `QueryDispatcher::Qcx` an associated type) - #151559 ([rustdoc] Add a marker to tell users that there are hidden (deprecated) items in the search results) - #151665 (Fix contrast ratio for `Since` element in rustodoc dark theme) - #151798 (Update `askama` to `0.15.3`) - #151800 (Subscribe myself to translation diagnostics)
Member
Author
rust-bors
bot
added
the
S-waiting-on-author
Contributor
|
Commit 1b762e2 has been unapproved. Auto build cancelled due to unapproval. Cancelled workflows: |
rust-bors
bot
removed
the
S-waiting-on-bors
Contributor
|
❗ There is currently no auto build in progress on this PR. |
rustbot
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
tests/ui/README.mdstays in sync #150474 (Tidy: detect ui tests subdirectory changes sotests/ui/README.mdstays in sync)AsyncFnclosures #150572 (Improve move error diagnostic forAsyncFnclosures)QueryDispatcher::Qcxan associated type #151802 (MakeQueryDispatcher::Qcxan associated type)Sinceelement in rustdoc dark theme #151665 (Fix contrast ratio forSinceelement in rustodoc dark theme)askamato0.15.3#151798 (Updateaskamato0.15.3)r? @ghost
Create a similar rollup