-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Fix x fix, again
#151766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix x fix, again
#151766
Conversation
|
hm, i'm positive this was working last week, but this week it seems to just be printing the JSON to stdout instead of applying the fixes ... |
|
oh, it fixed itself somehow ... well, we don't promise that |
This was refactored incorrectly at some point and would run `cargo check` even for `x fix`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that ./x fix is... vibes-based, this looks fine, thanks
|
@bors r+ rollup |
Rollup of 9 pull requests Successful merges: - #151239 (Support trait objects in type info reflection) - #150893 (offload: move (un)register lib into global_ctors) - #151013 (Add some clarifications and fixes for fmt syntax) - #151666 (compiler: Rename several types/traits for per-query vtables) - #151738 (Add `extern crate core` to diagnostic tests) - #151747 (Update `askama` version to `0.15.2`) - #151759 (Update `browser-ui-test` version to `0.23.3`) - #151763 (Add FileCheck annotations to simplify_match.rs) - #151766 (Fix `x fix`, again)
Rollup merge of #151766 - ferrocene:jyn/x-fix, r=jieyouxu Fix `x fix`, again This was refactored incorrectly at some point and would run `cargo check` even for `x fix`.
This was refactored incorrectly at some point and would run
cargo checkeven forx fix.