Skip to content

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 27, 2026

This was refactored incorrectly at some point and would run cargo check even for x fix.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 27, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jyn514
Copy link
Member Author

jyn514 commented Jan 27, 2026

hm, i'm positive this was working last week, but this week it seems to just be printing the JSON to stdout instead of applying the fixes ...

@jyn514
Copy link
Member Author

jyn514 commented Jan 27, 2026

oh, it fixed itself somehow ...

well, we don't promise that x fix works well, this at least lets people try it.

This was refactored incorrectly at some point and would run `cargo check`
even for `x fix`.
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that ./x fix is... vibes-based, this looks fine, thanks

View changes since this review

@jieyouxu
Copy link
Member

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 28, 2026

📌 Commit 6165b72 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2026
rust-bors bot pushed a commit that referenced this pull request Jan 28, 2026
Rollup of 9 pull requests

Successful merges:

 - #151239 (Support trait objects in type info reflection)
 - #150893 (offload: move (un)register lib into global_ctors)
 - #151013 (Add some clarifications and fixes for fmt syntax)
 - #151666 (compiler: Rename several types/traits for per-query vtables)
 - #151738 (Add `extern crate core` to diagnostic tests)
 - #151747 (Update `askama` version to `0.15.2`)
 - #151759 (Update `browser-ui-test` version to `0.23.3`)
 - #151763 (Add FileCheck annotations to simplify_match.rs)
 - #151766 (Fix `x fix`, again)
@rust-bors rust-bors bot merged commit 4d2c8e3 into rust-lang:main Jan 28, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Jan 28, 2026
Rollup merge of #151766 - ferrocene:jyn/x-fix, r=jieyouxu

Fix `x fix`, again

This was refactored incorrectly at some point and would run `cargo check` even for `x fix`.
@rustbot rustbot added this to the 1.95.0 milestone Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants