Skip to content

test: make 'append-elements' codegen test robust against newer LLVM IR #151760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexander-dreyzen wants to merge 6 commits into from
Closed

test: make 'append-elements' codegen test robust against newer LLVM IR #151760

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d989da
test: make 'append-elements' codegen test robust against newer LLVM IR
Jan 27, 2026
93d6eba
test: remove unused DST capture in 'append-elements' test
Jan 28, 2026
421b72a
test: link DST argument to memcpy in 'append-elements' test
Jan 28, 2026
f753617
tests: make append-elements.rs codegen test architecture-independent
Jan 28, 2026
cc09f1d
tests: link dst to memcpy in append-elements using arch-independent r…
Jan 28, 2026
b37a53e
tests: use robust one-liner FileCheck patterns in append-elements.rs
Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/codegen-llvm/lib-optimizations/append-elements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,23 @@
//! zero-capacity length flowing into the memcpy arguments.

// CHECK-LABEL: @vec_append_with_temp_alloc
// CHECK-SAME: ptr{{.*}}[[DST:%[a-z]+]]{{.*}}ptr{{.*}}[[SRC:%[a-z]+]]
// CHECK-SAME: (ptr {{[^%]+}}%[[DST:[a-z0-9._]+]], ptr {{[^%]+}}%[[SRC:[a-z0-9._]+]],
#[no_mangle]
pub fn vec_append_with_temp_alloc(dst: &mut Vec<u8>, src: &[u8]) {
// CHECK-NOT: call void @llvm.memcpy
// CHECK: call void @llvm.memcpy.{{.*}}[[DST]].i{{.*}}[[SRC]]
Copy link
Member

@scottmcm scottmcm Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help anyone else who might, like me, have missed it: note that there's a .i on here; it wasn't actually looking for a memcpy to the &mut Vec.

Makes me think that perhaps the test wants the GEP+load in the checks too?

// CHECK: call void @llvm.memcpy.{{.*}}ptr {{.*}}, ptr {{.*}}%[[SRC]]
// CHECK-NOT: call void @llvm.memcpy
let temp = src.to_vec();
dst.extend(&temp);
// CHECK: ret
}

// CHECK-LABEL: @string_append_with_temp_alloc
// CHECK-SAME: ptr{{.*}}[[DST:%[a-z]+]]{{.*}}ptr{{.*}}[[SRC:%[a-z]+]]
// CHECK-SAME: (ptr {{[^%]+}}%[[DST:[a-z0-9._]+]], ptr {{[^%]+}}%[[SRC:[a-z0-9._]+]],
#[no_mangle]
pub fn string_append_with_temp_alloc(dst: &mut String, src: &str) {
// CHECK-NOT: call void @llvm.memcpy
// CHECK: call void @llvm.memcpy.{{.*}}[[DST]].i{{.*}}[[SRC]]
// CHECK: call void @llvm.memcpy.{{.*}}ptr {{.*}}, ptr {{.*}}%[[SRC]]
// CHECK-NOT: call void @llvm.memcpy
let temp = src.to_string();
dst.push_str(&temp);
Expand Down
Loading