Skip to content

[stable] Don't try to recover keyword as non-keyword identifier #151714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tgross35 wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

[stable] Don't try to recover keyword as non-keyword identifier #151714

tgross35 wants to merge 2 commits into from

Conversation

@tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jan 27, 2026

@jieyouxu @tgross35
Add regression tests for keyword-in-identifier-position recovery ICE
4117c49 
... in macro invocations.

Issue: <rust-lang#149692>.
(cherry picked from commit 31531b3)
@jieyouxu @tgross35
Don't try to recover keyword as non-keyword identifier
e7f9800 
There's no sensible recovery scheme here, giving up the recovery is the
right thing to do.

(cherry picked from commit 79c4727)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jan 27, 2026

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20260115.477
Commit: 4b342d620503cbe250a3154040964899ea7c9b00
Build Date: 2026-01-15T22:32:41Z
Worker ID: {b8761893-0596-4121-ba9a-7fbddda34362}
Azure Region: westcentralus
##[endgroup]
##[group]Operating System
Ubuntu
24.04.3
LTS

@Mark-Simulacrum Mark-Simulacrum added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Jan 27, 2026
@mu001999
Copy link
Contributor

mu001999 commented Jan 27, 2026

I think we should backport also #151249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tgross35 @rustbot @rust-log-analyzer @mu001999 @Mark-Simulacrum @jieyouxu