Skip to content

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Jan 26, 2026

Some followups made possible by #151505.

@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Jan 26, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the rust-analyzer changes.

View changes since this review

@petrochenkov
Copy link
Contributor

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

📌 Commit 6e7a87c has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 27, 2026
…enkov

more `proc_macro` bridge cleanups

Some followups made possible by rust-lang#151505.
rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
…uwer

Rollup of 2 pull requests

Successful merges:

 - #151161 (std: move time implementations to `sys`)
 - #151694 (more `proc_macro` bridge cleanups)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 27, 2026
…enkov

more `proc_macro` bridge cleanups

Some followups made possible by rust-lang#151505.
rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #150491 (resolve: Mark items under exported ambiguous imports as exported)
 - #151161 (std: move time implementations to `sys`)
 - #151694 (more `proc_macro` bridge cleanups)
 - #151711 (stdarch subtree update)
rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151161 (std: move time implementations to `sys`)
 - #151694 (more `proc_macro` bridge cleanups)
 - #151711 (stdarch subtree update)
 - #150557 (Don't try to evaluate const blocks during constant promotion)
@rust-bors rust-bors bot merged commit 84bb764 into rust-lang:main Jan 27, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 27, 2026
rust-timer added a commit that referenced this pull request Jan 27, 2026
Rollup merge of #151694 - cyrgani:more-pm-cleanup, r=petrochenkov

more `proc_macro` bridge cleanups

Some followups made possible by #151505.
@cyrgani cyrgani deleted the more-pm-cleanup branch January 27, 2026 21:15
@nnethercote
Copy link
Contributor

Nice changes!

}
}

// FIXME(eddyb) generate these impls by pattern-matching on the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two thumbs up for eliminating one of these FIXME comments.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 28, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#151161 (std: move time implementations to `sys`)
 - rust-lang/rust#151694 (more `proc_macro` bridge cleanups)
 - rust-lang/rust#151711 (stdarch subtree update)
 - rust-lang/rust#150557 (Don't try to evaluate const blocks during constant promotion)
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Jan 29, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#151161 (std: move time implementations to `sys`)
 - rust-lang/rust#151694 (more `proc_macro` bridge cleanups)
 - rust-lang/rust#151711 (stdarch subtree update)
 - rust-lang/rust#150557 (Don't try to evaluate const blocks during constant promotion)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants