-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
more proc_macro bridge cleanups
#151694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more proc_macro bridge cleanups
#151694
Conversation
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
|
rustbot has assigned @petrochenkov. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the rust-analyzer changes.
|
@bors r+ |
…enkov more `proc_macro` bridge cleanups Some followups made possible by rust-lang#151505.
…enkov more `proc_macro` bridge cleanups Some followups made possible by rust-lang#151505.
|
Nice changes! |
| } | ||
| } | ||
|
|
||
| // FIXME(eddyb) generate these impls by pattern-matching on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two thumbs up for eliminating one of these FIXME comments.
…uwer Rollup of 4 pull requests Successful merges: - rust-lang/rust#151161 (std: move time implementations to `sys`) - rust-lang/rust#151694 (more `proc_macro` bridge cleanups) - rust-lang/rust#151711 (stdarch subtree update) - rust-lang/rust#150557 (Don't try to evaluate const blocks during constant promotion)
…uwer Rollup of 4 pull requests Successful merges: - rust-lang/rust#151161 (std: move time implementations to `sys`) - rust-lang/rust#151694 (more `proc_macro` bridge cleanups) - rust-lang/rust#151711 (stdarch subtree update) - rust-lang/rust#150557 (Don't try to evaluate const blocks during constant promotion)
Some followups made possible by #151505.