Fix compilation of std/src/sys/pal/uefi/tests.rs #151555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropped the `align` test since the `POOL_ALIGNMENT` and `align_size` items it uses do not exist. The other changes are straightforward fixes for places where the test code drifted from the current API, since the tests are not yet built in CI for the UEFI target.
rustbot
added
S-waiting-on-review
Collaborator
tgross35
approved these changes
Jan 24, 2026
Comment on lines
+250
to
+251
| assert_eq!(data, io_slice_mut.deref()); | ||
| assert_eq!(data, io_slice_mut.deref_mut()); |
Contributor
There was a problem hiding this comment.
Clippy would probably tell you to do &*io_slice_mut and &mut *io_slice_mut so you don't need to import Deref/DerefMut, but it's not a problem of course
Contributor
|
LGTM, thanks! @bors r=Ayush1325,tgross35 rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jan 24, 2026
…i-test, r=Ayush1325,tgross35 Fix compilation of std/src/sys/pal/uefi/tests.rs Dropped the `align` test since the `POOL_ALIGNMENT` and `align_size` items it uses do not exist. The other changes are straightforward fixes for places where the test code drifted from the current API, since the tests are not yet built in CI for the UEFI target. CC @Ayush1325
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 24, 2026
Rollup of 8 pull requests Successful merges: - #150556 (Add Tier 3 Thumb-mode targets for Armv7-A, Armv7-R and Armv8-R) - #151500 (hexagon: Add HVX target features) - #151505 (Various refactors to the proc_macro bridge) - #151517 (Enable reproducible binary builds with debuginfo on Linux) - #151482 (Add "Skip to main content" link for keyboard navigation in rustdoc) - #151489 (constify boolean methods) - #151551 (Don't use default build-script fingerprinting in `test`) - #151555 (Fix compilation of std/src/sys/pal/uefi/tests.rs) r? @ghost
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 24, 2026
…i-test, r=Ayush1325,tgross35 Fix compilation of std/src/sys/pal/uefi/tests.rs Dropped the `align` test since the `POOL_ALIGNMENT` and `align_size` items it uses do not exist. The other changes are straightforward fixes for places where the test code drifted from the current API, since the tests are not yet built in CI for the UEFI target. CC @Ayush1325
This was referenced Jan 24, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 24, 2026
…uwer Rollup of 8 pull requests Successful merges: - #150556 (Add Tier 3 Thumb-mode targets for Armv7-A, Armv7-R and Armv8-R) - #151259 (Fix is_ascii performance regression on AVX-512 CPUs when compiling with -C target-cpu=native) - #151500 (hexagon: Add HVX target features) - #151517 (Enable reproducible binary builds with debuginfo on Linux) - #151482 (Add "Skip to main content" link for keyboard navigation in rustdoc) - #151489 (constify boolean methods) - #151551 (Don't use default build-script fingerprinting in `test`) - #151555 (Fix compilation of std/src/sys/pal/uefi/tests.rs) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 24, 2026
Rollup merge of #151555 - nicholasbishop:bishop-fix-just-uefi-test, r=Ayush1325,tgross35 Fix compilation of std/src/sys/pal/uefi/tests.rs Dropped the `align` test since the `POOL_ALIGNMENT` and `align_size` items it uses do not exist. The other changes are straightforward fixes for places where the test code drifted from the current API, since the tests are not yet built in CI for the UEFI target. CC @Ayush1325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped the
aligntest since thePOOL_ALIGNMENTandalign_sizeitems it uses do not exist.The other changes are straightforward fixes for places where the test code drifted from the current API, since the tests are not yet built in CI for the UEFI target.
CC @Ayush1325