Clean up or resolve cfg-related instances of FIXME(f16_f128)#151527
Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom Jan 23, 2026
Merged
Clean up or resolve cfg-related instances of FIXME(f16_f128)#151527rust-bors[bot] merged 4 commits intorust-lang:mainfrom
FIXME(f16_f128)#151527rust-bors[bot] merged 4 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
tgross35
changed the title
FIXME(f16_f128)
tgross35
force-pushed
the
f16-fixme-cleanup
branch
2 times, most recently
from
749e883 to
80ada96
Compare
rustbot
added
the
A-LLVM
tgross35
changed the title
FIXME(f16_f128)FIXME(f16_f128)
There are a number of instances of `FIXME(f16_f128)` related to target configuration; either these could use `target_has_reliable_f128`, or the FIXME is describing such a cfg and is thus redundant (since any `cfg(target_has_reliable_f*)` needs to be removed before stabilization anyway). Switch to using `target_has_reliable_*` where applicable and remove the redundant FIXMEs.
This FIXME was introduced in 6e2d934 ("Add more `f16` and `f128` library functions and constants") but I can't actually find my reasoning. As far as I can tell, LLVM has been lowering `fabs.f128` as bitwise operations for a while across all targets so there shouldn't be a problem here. Thus, apply what is suggested in the FIXME.
…6,f128` Make it easier to identify which FIXMEs are blocking stabilization of which type.
tgross35
force-pushed
the
f16-fixme-cleanup
branch
from
80ada96 to
490b307
Compare
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
Contributor
Author
|
r? @folkertdev |
Contributor
|
Nice, looks good. @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
…uwer Rollup of 5 pull requests Successful merges: - #149639 (inline constant localized typeck constraint computation) - #150780 (Add -Z large-data-threshold) - #151520 (Rename `HandleCycleError` to `CycleErrorHandling`) - #151525 (update enzyme, includes an extra patch to fix MacOS builds in CI) - #151527 (Clean up or resolve cfg-related instances of `FIXME(f16_f128)`) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 23, 2026
Rollup merge of #151527 - tgross35:f16-fixme-cleanup, r=folkertdev Clean up or resolve cfg-related instances of `FIXME(f16_f128)` * Replace target-specific config that has a `FIXME` with `cfg(target_has_reliable_f*)` * Take care of trivial intrinsic-related FIXMEs * Split `FIXME(f16_f128)` into `FIXME(f16)`, `FIXME(f128)`, or `FIXME(f16,f128)` to more clearly identify what they block The individual commit messages have more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXMEwithcfg(target_has_reliable_f*)FIXME(f16_f128)intoFIXME(f16),FIXME(f128), orFIXME(f16,f128)to more clearly identify what they blockThe individual commit messages have more details.