-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Add "Skip to main content" link for keyboard navigation in rustdoc #151482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+40
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // This test ensures that the "Skip to main content" link works correctly | ||
| // for keyboard navigation (WCAG 2.4.1 compliance). | ||
| go-to: "file://" + |DOC_PATH| + "/test_docs/index.html" | ||
|
|
||
| // The skip link should be hidden initially (positioned off-screen above viewport) | ||
| store-position: (".skip-main-content", {"y": y_before}) | ||
| store-size: (".skip-main-content", {"height": height_before}) | ||
| assert: |y_before| + |height_before| < 0 | ||
|
|
||
| // The skip link should be the first focusable element when pressing Tab | ||
| press-key: "Tab" | ||
| wait-for: ".skip-main-content:focus" | ||
|
|
||
| // When focused, the link should be visible (top: 0px) | ||
| assert-css: (".skip-main-content:focus", {"top": "0px"}) | ||
GuillaumeGomez marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Pressing Enter on the skip link should move focus to main content | ||
| press-key: "Enter" | ||
| wait-for: "#main-content:focus" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Are these styles really necessary?