std: use clock_nanosleep for sleep where available
#151450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
joboet
force-pushed
the
sleep_clock_monotonic
branch
from
a7a0704 to
443765e
Compare
Member
|
r=me on the wasi side of things, thanks! |
Member
|
LGTM for the other platforms. @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
Rollup of 4 pull requests Successful merges: - #151450 (std: use `clock_nanosleep` for `sleep` where available) - #151494 (std: ensure that the deadline has passed in `sleep_until`) - #151498 (global.rs: improve readability of re-entrance section) - #151504 (Reorganizing tests/ui/issues 11 tests [3/N]) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 23, 2026
Rollup merge of #151450 - joboet:sleep_clock_monotonic, r=Amanieu std: use `clock_nanosleep` for `sleep` where available `nanosleep` is specified to use `CLOCK_REALTIME` but the documentation (especially the example) for `sleep` imply that it measures time using `Instant`, which uses `CLOCK_MONOTONIC`. Thus, this PR makes `sleep` use a relative `clock_nanosleep` with `CLOCK_MONOTONIC` where available. This doesn't make a difference for Linux (which uses `CLOCK_MONOTONIC` for `nanosleep` anyway) but is relevant for e.g. FreeBSD. This also restores nanosecond-sleep precision for WASI, since #150290 was caused by `nanosleep` internally using `clock_nanosleep` with `CLOCK_REALTIME` which is unsupported on WASIp2. CC @alexcrichton for the WASI fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nanosleepis specified to useCLOCK_REALTIMEbut the documentation (especially the example) forsleepimply that it measures time usingInstant, which usesCLOCK_MONOTONIC. Thus, this PR makessleepuse a relativeclock_nanosleepwithCLOCK_MONOTONICwhere available. This doesn't make a difference for Linux (which usesCLOCK_MONOTONICfornanosleepanyway) but is relevant for e.g. FreeBSD.This also restores nanosecond-sleep precision for WASI, since #150290 was caused by
nanosleepinternally usingclock_nanosleepwithCLOCK_REALTIMEwhich is unsupported on WASIp2.CC @alexcrichton for the WASI fix