Fix terminal width dependent tests #151375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
rustbot
added
A-rustc-dev-guide
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
BoxyUwU
changed the title
lqd
reviewed
Jan 19, 2026
| @@ -1,4 +1,5 @@ | |||
| //@ compile-flags: -Z ui-testing=no | |||
| //@ compile-flags: --diagnostic-width=80 | |||
Member
There was a problem hiding this comment.
You could combine the new flag with the existing flags just above and avoid changing the test expectations
Member
Author
There was a problem hiding this comment.
shocking that the directive called compile-flags (plural) would let me write multiple things on one line 😆 good call
BoxyUwU
force-pushed
the
terminal_width_independence
branch
from
df738bb to
f6571c0
Compare
BoxyUwU
force-pushed
the
terminal_width_independence
branch
from
f6571c0 to
8a57358
Compare
lqd
approved these changes
Jan 19, 2026
Member
Author
|
@bors r=lqd rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
jieyouxu
approved these changes
Jan 19, 2026
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 20, 2026
Fix terminal width dependent tests [#t-compiler > What is -Zui-testing=no and why are we using it](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/What.20is.20-Zui-testing.3Dno.20and.20why.20are.20we.20using.20it/with/568842970) See zulip thread. I've verified locally that this lets me run the ui test suite without problems even with a very thin terminal 😆
This was referenced Jan 20, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
Rollup of 8 pull requests Successful merges: - #149587 (coverage: Sort the expansion tree to help choose a single BCB for child expansions) - #150071 (Add dist step for Enzyme) - #150288 (Add scalar support for offload) - #151091 (Add new "hide deprecated items" setting in rustdoc) - #151255 (rustdoc: Fix ICE when deprecated note is not resolved on the correct `DefId`) - #151375 (Fix terminal width dependent tests) - #151384 (add basic `TokenStream` api tests) - #151391 (rustc-dev-guide subtree update) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 20, 2026
Rollup merge of #151375 - terminal_width_independence, r=lqd Fix terminal width dependent tests [#t-compiler > What is -Zui-testing=no and why are we using it](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/What.20is.20-Zui-testing.3Dno.20and.20why.20are.20we.20using.20it/with/568842970) See zulip thread. I've verified locally that this lets me run the ui test suite without problems even with a very thin terminal 😆
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 20, 2026
Rollup of 8 pull requests Successful merges: - rust-lang/rust#149587 (coverage: Sort the expansion tree to help choose a single BCB for child expansions) - rust-lang/rust#150071 (Add dist step for Enzyme) - rust-lang/rust#150288 (Add scalar support for offload) - rust-lang/rust#151091 (Add new "hide deprecated items" setting in rustdoc) - rust-lang/rust#151255 (rustdoc: Fix ICE when deprecated note is not resolved on the correct `DefId`) - rust-lang/rust#151375 (Fix terminal width dependent tests) - rust-lang/rust#151384 (add basic `TokenStream` api tests) - rust-lang/rust#151391 (rustc-dev-guide subtree update) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#t-compiler > What is -Zui-testing=no and why are we using it
See zulip thread. I've verified locally that this lets me run the ui test suite without problems even with a very thin terminal 😆