Fix #15129 #15130
Closed
Fix #15129 #15130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It's unfortunate this pattern matching refactor had led to so many regressions but at least we're building up test coverage the hard way. Hopefully after all the changes I'd like to make, the whole thing will be in a much better shape! |
Author
|
I've now added a test for this as well: which happily compiled in master. |
Member
|
Looks like this needs a rebase |
Author
|
@alexcrichton Done. |
ghost
deleted the
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Jun 26, 2025
Add beta-accepted to CHANGELOG for 1.88 since it was missed at rust-lang/rust-clippy#5095 changelog: none r? flip1995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for unit literals to const_eval.