Recover from struct literals with placeholder or empty path

[Unique-Usman]

Based on earlier work by León Orell Valerian Liehr.

[rustbot]

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Unique-Usman]

r? @estebank

[Unique-Usman]

@estebank as discussed last week monday, I have retrieved the issue previous pr by @fmease from #122288 and I will be updating and adding the changes here. Thank you.

[Unique-Usman]

r? @estebank

[rustbot]

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

[estebank]

The earlier comments are still relevant.

Run ./x.py test tests/ui --bless to update all the .stderr files.

View changes since this review

[estebank]

As discussed, lets do the parser changes first and the resolve changes in a separate PR.

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[Unique-Usman]

As discussed, lets do the parser changes first and the resolve changes in a separate PR.

View changes since this review

yep, noted.

[Unique-Usman]

With this pr.

This

fn main() {
    let _ = {foo: (), bar: {} };
    let _ = _ {foo: (), bar: {} };
    let _ = {foo: ()};
    let _ = _ {foo: ()};
}

previous

error: struct literal body without path
 --> src/main.rs:2:13
  |
2 |     let _ = {foo: (), bar: {} };
  |             ^^^^^^^^^^^^^^^^^^^
  |
help: you might have forgotten to add the struct literal inside the block
  |
2 |     let _ = { SomeStruct {foo: (), bar: {} } };
  |             ++++++++++++                     +

error: expected one of `.`, `;`, `?`, `else`, or an operator, found `{`
 --> src/main.rs:3:15
  |
3 |     let _ = _ {foo: (), bar: {} };
  |               ^ expected one of `.`, `;`, `?`, `else`, or an operator

error: could not compile `playground` (bin "playground") due to 2 previous errors

current

error: struct literal body without path
 --> testing.rs:2:12
  |
2 |     let _ = {foo: (), bar: {} };
  |            ^^^^^^^^^^^^^^^^^^^^
  |            |
  |            absent of struct name for this struct literals
  |            help: add the correct type: `/*Type*/`

error: the placeholder `_` is not allowed for the path in struct literals
 --> testing.rs:3:13
  |
3 |     let _ = _ {foo: (), bar: {} };
  |             ^^^^^^^^^^^^^^^^^^^^^
  |             |
  |             not allowed in struct literals
  |             help: replace it with the correct type: `/*Type*/`

error: struct literal body without path
 --> testing.rs:4:12
  |
4 |     let _ = {foo: ()};
  |            ^^^^^^^^^^
  |            |
  |            absent of struct name for this struct literals
  |            help: add the correct type: `/*Type*/`

error: the placeholder `_` is not allowed for the path in struct literals
 --> testing.rs:5:13
  |
5 |     let _ = _ {foo: ()};
  |             ^^^^^^^^^^^
  |             |
  |             not allowed in struct literals
  |             help: replace it with the correct type: `/*Type*/`

error: aborting due to 4 previous errors

[estebank]

CC #98282 and #105398. We still need to rely on resolve to get the appropriate type path when possible.

[JonathanBrouwer]

@bors yield
Yielding to enclosing rollup

[rust-bors]

Auto build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/21366992121

The next pull request likely to be tested is #151701.

[JonathanBrouwer]

@bors yield
Yielding to enclosing rollup

[rust-bors]

Auto build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/21367236037

The next pull request likely to be tested is #151701.

[rust-bors]

💔 Test for 6dd470c failed: CI. Failed job:

• auto - x86_64-mingw-1 (web logs, enhanced plaintext logs)

[JonathanBrouwer]

@bors retry
Spurious

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[error]Could not find a part of the path 'D:\a'.

[estebank]

@bors retry
Spurious

[rust-bors]

❗ You can only retry pull requests that are approved and have a previously failed auto build.

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[error]Could not find a part of the path 'D:\a'.