Normalize type_const items even with feature generic_const_exprs
#151275
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
S-waiting-on-review
rustbot
added
S-waiting-on-author
mu001999
changed the title
generic_const_exprs
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-review
Member
|
@bors r+ rollup thanks :) |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Member
|
Though for future reference, if a problem with mGCA is only reproducible with generic_const_exprs then I think it's usually not worth fixing. It depends a little on whether we expect the underlying problem to occur with other const generics features or not (which can be kinda hard to judge). |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 18, 2026
Normalize type_const items even with feature `generic_const_exprs` Fixes rust-lang#151251 With feature `generic_const_exprs` enabled, consts with `#[type_const]` won't be normalized even if they need. Then ICE happens when CTFE tries to evaluate such const without body. Fix this by normalizing such consts even with feature `generic_const_exprs` enabled. r? @BoxyUwU
This was referenced Jan 18, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 18, 2026
…uwer Rollup of 7 pull requests Successful merges: - #150767 (Allow invoking all help options at once) - #150886 (Added mGCA related tests) - #151245 (Explicitly list crate level attrs) - #151268 (Fix ICE on inconsistent import resolution with macro-attributed extern crate) - #151275 (Normalize type_const items even with feature `generic_const_exprs`) - #151288 (Use `find_attr` instead of `attr::contains_name` in `lower_const_item_rhs`) - #151321 (Port #![no_main] to the attribute parser.) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 18, 2026
Rollup merge of #151275 - fix/151251, r=BoxyUwU Normalize type_const items even with feature `generic_const_exprs` Fixes #151251 With feature `generic_const_exprs` enabled, consts with `#[type_const]` won't be normalized even if they need. Then ICE happens when CTFE tries to evaluate such const without body. Fix this by normalizing such consts even with feature `generic_const_exprs` enabled. r? @BoxyUwU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151251
With feature
generic_const_exprsenabled, consts with#[type_const]won't be normalized even if they need. Then ICE happens when CTFE tries to evaluate such const without body.Fix this by normalizing such consts even with feature
generic_const_exprsenabled.r? @BoxyUwU