Skip to content

Fix ICE on inconsistent import resolution with macro-attributed extern crate #151268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Jan 18, 2026
Merged

Fix ICE on inconsistent import resolution with macro-attributed extern crate #151268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_resolve/src/imports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
PathResult::Module(module) => {
// Consistency checks, analogous to `finalize_macro_resolutions`.
if let Some(initial_module) = import.imported_module.get() {
if module != initial_module && no_ambiguity {
if module != initial_module && no_ambiguity && !self.issue_145575_hack_applied {
span_bug!(import.span, "inconsistent resolution for an import");
}
} else if self.privacy_errors.is_empty() {
Expand Down
14 changes: 14 additions & 0 deletions tests/ui/resolve/ice-inconsistent-resolution-151213.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
//@ edition: 2024

#[attr]
//~^ ERROR cannot find attribute `attr` in this scope
extern crate core as std;
//~^ ERROR macro-expanded `extern crate` items cannot shadow names passed with `--extern`

mod inner {
use std::str;

use crate::*;
}

fn main() {}
14 changes: 14 additions & 0 deletions tests/ui/resolve/ice-inconsistent-resolution-151213.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
error: macro-expanded `extern crate` items cannot shadow names passed with `--extern`
--> $DIR/ice-inconsistent-resolution-151213.rs:5:1
|
LL | extern crate core as std;
| ^^^^^^^^^^^^^^^^^^^^^^^^^

error: cannot find attribute `attr` in this scope
--> $DIR/ice-inconsistent-resolution-151213.rs:3:3
|
LL | #[attr]
| ^^^^

error: aborting due to 2 previous errors

Loading