f16: remove s390x fixme
#151261
Closed
f16: remove s390x fixme
#151261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
added
O-SystemZ
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
f16-remove-s390x-fixme
branch
from
98e02d5 to
d646e85
Compare
This comment has been minimized.
This comment has been minimized.
LLVM issue 50374 was closed a while ago, and the fix made it into LLVM 21, so these examples no longer crash
folkertdev
force-pushed
the
f16-remove-s390x-fixme
branch
from
d646e85 to
05f832e
Compare
Contributor
Author
|
superseded by #151468 |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #116909
The fix for llvm/llvm-project#50374 made it into LLVM 21, so these examples work now.
https://rust.godbolt.org/z/qTzMG4ffc
But the doc tests only ran on x86_64 linux before, so removing the
cfgmakes them suddenly run on many more targets, some of which might still fail. We may need to wait until we're on LLVM 22 if other issues do pop up.r? @tgross35