option: Use Option::map in Option::cloned #151220

cvengler · 2026-01-16T17:16:35Z

This commit removes a repetitive match statement in favor of Option::map for Option::cloned.

rustbot · 2026-01-16T17:16:40Z

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Bryntet · 2026-01-16T20:21:43Z

this could be self.map(T::clone) which is more idiomatic IMO

cvengler · 2026-01-18T15:52:16Z

this could be self.map(T::clone) which is more idiomatic IMO

Good catch, fixed.

This commit removes a repetitive match statement in favor of Option::map for Option::cloned.

tgross35 · 2026-01-22T06:22:36Z

LGTM, thanks for the patch

@bors r+

this could be self.map(T::clone) which is more idiomatic IMO

Good catch, fixed.

For reference, the self.map(|x| x.clone()) pattern was probably intentionally avoided because closures in heavily-used inlined methods can slow down compile times. But afaik passing the actual method isn't an issue.

rust-bors · 2026-01-22T06:22:39Z

📌 Commit 85200a4 has been approved by tgross35

It is now in the queue for this repository.

option: Use Option::map in Option::cloned This commit removes a repetitive match statement in favor of Option::map for Option::cloned.

@ghost

…uwer Rollup of 8 pull requests Successful merges: - #148206 (Deduplicated float tests and unified in floats/mod.rs) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

@ghost

…uwer Rollup of 8 pull requests Successful merges: - #148206 (Deduplicated float tests and unified in floats/mod.rs) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

@ghost

…uwer Rollup of 8 pull requests Successful merges: - #148206 (Deduplicated float tests and unified in floats/mod.rs) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

@ghost

…uwer Rollup of 11 pull requests Successful merges: - #151001 (rustdoc: render doc(hidden) as a code attribute) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151296 (MGCA: Fix incorrect pretty printing of valtree arrays) - #151423 (Move assert_matches to planned stable path) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151468 (fix `f16` doctest FIXMEs) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

rust-bors · 2026-01-22T14:15:47Z

⌛ Testing commit 85200a4 with merge c94dec2...

Workflow: https://github.com/rust-lang/rust/actions/runs/21251749592

option: Use Option::map in Option::cloned This commit removes a repetitive match statement in favor of Option::map for Option::cloned.

@ghost

…uwer Rollup of 11 pull requests Successful merges: - #151001 (rustdoc: render doc(hidden) as a code attribute) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151296 (MGCA: Fix incorrect pretty printing of valtree arrays) - #151423 (Move assert_matches to planned stable path) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151468 (fix `f16` doctest FIXMEs) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

JonathanBrouwer · 2026-01-22T14:33:29Z

@bors retry
Spurious

rust-log-analyzer · 2026-01-22T14:35:15Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@ghost

…uwer Rollup of 11 pull requests Successful merges: - #151001 (rustdoc: render doc(hidden) as a code attribute) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151296 (MGCA: Fix incorrect pretty printing of valtree arrays) - #151423 (Move assert_matches to planned stable path) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151468 (fix `f16` doctest FIXMEs) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

Rollup merge of #151220 - cvengler:map-option, r=tgross35 option: Use Option::map in Option::cloned This commit removes a repetitive match statement in favor of Option::map for Option::cloned.

@ghost

…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#151001 (rustdoc: render doc(hidden) as a code attribute) - rust-lang/rust#151042 (fix fallback impl for select_unpredictable intrinsic) - rust-lang/rust#151220 (option: Use Option::map in Option::cloned) - rust-lang/rust#151260 (Handle unevaluated ConstKind in in_operand) - rust-lang/rust#151296 (MGCA: Fix incorrect pretty printing of valtree arrays) - rust-lang/rust#151423 (Move assert_matches to planned stable path) - rust-lang/rust#151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - rust-lang/rust#151465 (codegen: clarify some variable names around function calls) - rust-lang/rust#151468 (fix `f16` doctest FIXMEs) - rust-lang/rust#151469 (llvm: Tolerate dead_on_return attribute changes) - rust-lang/rust#151476 (Avoid `-> ()` in derived functions.) r? @ghost

rustbot assigned tgross35 Jan 16, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 16, 2026

cvengler force-pushed the map-option branch from fdf4f4c to ad1bd87 Compare January 18, 2026 15:51

This comment has been minimized.

Sign in to view

option: Use Option::map in Option::cloned

85200a4

This commit removes a repetitive match statement in favor of Option::map for Option::cloned.

cvengler force-pushed the map-option branch from ad1bd87 to 85200a4 Compare January 18, 2026 17:46

tgross35 approved these changes Jan 22, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2026

JonathanBrouwer mentioned this pull request Jan 22, 2026

Rollup of 5 pull requests #151484

Closed

JonathanBrouwer mentioned this pull request Jan 22, 2026

Rollup of 8 pull requests #151485

Closed

JonathanBrouwer mentioned this pull request Jan 22, 2026

Rollup of 11 pull requests #151490

Merged

rust-bors bot pushed a commit that referenced this pull request Jan 22, 2026

Auto merge of #151220 - cvengler:map-option, r=tgross35

c94dec2

option: Use Option::map in Option::cloned This commit removes a repetitive match statement in favor of Option::map for Option::cloned.

rust-bors bot merged commit 4fb420a into rust-lang:main Jan 22, 2026
11 of 12 checks passed

rustbot added this to the 1.95.0 milestone Jan 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

option: Use Option::map in Option::cloned #151220

option: Use Option::map in Option::cloned #151220

Uh oh!

cvengler commented Jan 16, 2026

Uh oh!

rustbot commented Jan 16, 2026

Uh oh!

Bryntet commented Jan 16, 2026

Uh oh!

cvengler commented Jan 18, 2026

Uh oh!

This comment has been minimized.

tgross35 commented Jan 22, 2026

Uh oh!

rust-bors bot commented Jan 22, 2026

Uh oh!

rust-bors bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer commented Jan 22, 2026

Uh oh!

rust-log-analyzer commented Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

option: Use Option::map in Option::cloned #151220

option: Use Option::map in Option::cloned #151220

Uh oh!

Conversation

cvengler commented Jan 16, 2026

Uh oh!

rustbot commented Jan 16, 2026

Uh oh!

Bryntet commented Jan 16, 2026

Uh oh!

cvengler commented Jan 18, 2026

Uh oh!

This comment has been minimized.

tgross35 commented Jan 22, 2026

Uh oh!

rust-bors bot commented Jan 22, 2026

Uh oh!

rust-bors bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jan 22, 2026

Uh oh!

rust-log-analyzer commented Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rust-bors bot commented Jan 22, 2026 •

edited

Loading