Use an associated type default for Key::Cache.
#151097
Merged
+4
−278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
|
Contributor
Author
|
@ChayimFriedman2: please let me know if we need to wait on this merging for any reason. |
This comment has been minimized.
This comment has been minimized.
Contributor
This should be available on r-a releases and on nightly rustup, I think that's enough. |
Member
|
r=me |
This comment has been minimized.
This comment has been minimized.
They currently aren't used because r-a didn't support them, but r-a support was recently merged in rust-lang/rust-analyzer#21243.
nnethercote
force-pushed
the
associated_type_defaults-query-key
branch
from
449f292 to
aebcf78
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=Noratrieb rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
Rollup of 5 pull requests Successful merges: - #151692 (Try to reduce rustdoc GUI tests flakyness) - #147436 (slice/ascii: Optimize `eq_ignore_ascii_case` with auto-vectorization) - #151390 (Reintroduce `QueryStackFrame` split.) - #151097 (Use an associated type default for `Key::Cache`.) - #151702 (Omit standard copyright notice)
rust-timer
added a commit
that referenced
this pull request
Jan 27, 2026
Rollup merge of #151097 - nnethercote:associated_type_defaults-query-key, r=Noratrieb Use an associated type default for `Key::Cache`. They currently aren't used because r-a didn't support them, but r-a support was recently merged in rust-lang/rust-analyzer#21243. r? @Noratrieb
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 28, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#151692 (Try to reduce rustdoc GUI tests flakyness) - rust-lang/rust#147436 (slice/ascii: Optimize `eq_ignore_ascii_case` with auto-vectorization) - rust-lang/rust#151390 (Reintroduce `QueryStackFrame` split.) - rust-lang/rust#151097 (Use an associated type default for `Key::Cache`.) - rust-lang/rust#151702 (Omit standard copyright notice)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They currently aren't used because r-a didn't support them, but r-a support was recently merged in
rust-lang/rust-analyzer#21243.
r? @Noratrieb