Skip to content

Avoid should-fail in two ui tests and a codegen-llvm test #151067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 2 commits into from
Jan 14, 2026
Merged

Avoid should-fail in two ui tests and a codegen-llvm test #151067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8afa95d
Avoid should-fail in two ui tests
bjorn3 Jan 13, 2026
15112ee
Avoid should-fail in a codegen-llvm test
bjorn3 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/codegen-llvm/option-niche-unfixed/option-nonzero-eq.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
//@ should-fail
//@ known-bug: #49892
//@ compile-flags: -Copt-level=3 -Zmerge-functions=disabled
//! FIXME(#49892)
//! Test that the derived implementation of `PartialEq` for `Option` is not fully
//! optimized by LLVM. If this starts passing, the test and manual impl should
//! be removed.
Expand All @@ -18,7 +17,7 @@ pub enum Option<T> {
#[no_mangle]
pub fn non_zero_eq(l: Option<NonZero<u32>>, r: Option<NonZero<u32>>) -> bool {
// CHECK: start:
// CHECK-NEXT: icmp eq i32
// CHECK-NEXT: ret i1
// COMMENTEDCHECK-NEXT: icmp eq i32
// COMMENTEDCHECK-NEXT: ret i1
l == r
}
2 changes: 1 addition & 1 deletion tests/ui/borrowck/two-phase-reservation-sharing-interference.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// The nll_beyond revision is disabled due to missing support from two-phase beyond autorefs
//@ unused-revision-names: nll_beyond
//@[nll_beyond]compile-flags: -Z two-phase-beyond-autoref
//@[nll_beyond]should-fail
//@[nll_beyond]check-fail

// This is a corner case that the current implementation is (probably)
// treating more conservatively than is necessary. But it also does
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/type-inference/box_has_sigdrop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//@ should-fail
//@ known-bug: unknown
//@ compile-flags: -Wrust-2021-incompatible-closure-captures
// Inference, canonicalization, and significant drops should work nicely together.
// Related issue: #86868
Expand Down
Loading