Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 11, 2026

Now that new bors knows how to use the old homu e-mail address (rust-lang/bors#614), we can revert to the old address. I modified the code to keep compatibility with both addresses, so that everything should still work for every merged commit in the past few days. In a few weeks/months, we could remove the temporary bors e-mail address, as at that point no one will likely care about these few merged commits anymore.

Should not be merged until rust-lang/bors#614 is deployed, although the current version in main should already mostly work with both addresses, except for CI postprocessing statistics.

Should be backported.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jan 11, 2026
@rust-log-analyzer

This comment has been minimized.

@Kobzol Kobzol marked this pull request as ready for review January 12, 2026 07:19
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 12, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kobzol
Copy link
Member Author

Kobzol commented Jan 12, 2026

@bors p=10

@marcoieni
Copy link
Member

@bors r+

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 12, 2026

📌 Commit ad713ab has been approved by marcoieni

It is now in the queue for this repository.

@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 12, 2026

☀️ Test successful - CI
Approved by: marcoieni
Pushing b115ea2 to main...

@rust-bors rust-bors bot merged commit b115ea2 into rust-lang:main Jan 12, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 12, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 561364e (parent) -> b115ea2 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b115ea2e6a07e440e7cc18b08644fc0a2265391b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 6828.1s -> 9467.1s (+38.7%)
  2. aarch64-apple: 8241.1s -> 10998.0s (+33.5%)
  3. dist-x86_64-apple: 7863.9s -> 6736.5s (-14.3%)
  4. dist-apple-various: 4346.5s -> 4969.1s (+14.3%)
  5. aarch64-msvc-2: 5847.9s -> 6525.2s (+11.6%)
  6. x86_64-gnu-nopt: 7869.2s -> 8767.2s (+11.4%)
  7. dist-aarch64-msvc: 5622.2s -> 6197.1s (+10.2%)
  8. dist-x86_64-illumos: 5965.2s -> 6567.6s (+10.1%)
  9. pr-check-1: 1834.2s -> 1687.7s (-8.0%)
  10. x86_64-gnu-miri: 4237.3s -> 4559.8s (+7.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Kobzol Kobzol deleted the bors-email-3 branch January 12, 2026 13:28
@Kobzol Kobzol added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 12, 2026
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b115ea2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.0% [-2.0%, -2.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.02s -> 473.644s (-0.08%)
Artifact size: 391.39 MiB -> 391.40 MiB (0.00%)

@cuviper cuviper added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 12, 2026
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 17, 2026
rust-bors bot pushed a commit that referenced this pull request Jan 18, 2026
[beta] backports

*  [beta] Disable SimplifyComparisonIntegral #151267 
*  Use the old homu bors e-mail address again #150959 

Does not backport other nominated PRs:

* Only use SSA locals in SimplifyComparisonIntegral #150925  (replaced with the disablement PR)
* Don't try to evaluate const blocks during constant promotion #150557 (backport essentially denied at this point)
* Use realstd current thread static variables in tests #150131 (as far as I can tell, this only affects internal std tests and hasn't landed in time for backport)

r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants