Convert static lifetime to an nll var #150764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Contributor
|
r=me after CI |
BoxyUwU
force-pushed
the
map_regions_for_outlives
branch
from
5257d68 to
3d965bd
Compare
Member
Author
|
r? lcnr |
Member
Author
|
@bors r=lcnr rollup |
Collaborator
rust-bors
bot
added
the
S-waiting-on-bors
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
Contributor
rust-bors
bot
removed
the
S-waiting-on-review
rust-timer
added a commit
that referenced
this pull request
Jan 8, 2026
Rollup merge of #150764 - map_regions_for_outlives, r=lcnr Convert static lifetime to an nll var Fixes #150648 I don't think this matters for any non 'static lifetimes as defining the struct as `Wrap<'a>` would mean the lifetime argument gets replaced with an nll var before MIR type checking meaning the struct tail is `dyn Trait + '?x` r? types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150648
I don't think this matters for any non 'static lifetimes as defining the struct as
Wrap<'a>would mean the lifetime argument gets replaced with an nll var before MIR type checking meaning the struct tail isdyn Trait + '?xr? types