-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
stdarch subtree update #150639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdarch subtree update #150639
Conversation
…ly use `f16` in the signature
Some test utility functions (e.g., `assert_eq_m128`) have been refactored so they are not unsafe. Many test functions (`test_mm_*`) do not call any unsafe function (besides needing target features) anymore, so they do not need to be `unsafe fn`.
(Partially) Stabilize `stdarch_neon_f16`
Fix some tests so they test the correct function
(Partially) Stabilize AVX512-FP16
x86: remove "unsafe" from tests that do not need it
This updates the rust-version file to 4862272.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 4862272 Filtered ref: cd67a857259ae6c8e166020f097dd070d6c16fb3 Upstream diff: rust-lang/rust@8401398...4862272 This merge was created using https://github.com/rust-lang/josh-sync.
Clarify documentation around "undefined" bits in intrinsics.
Use LLVM intrinsics for `madd` intrinsics
`repr(packed)` structs do not have a well-defined layout
Change `repr(packed)` struct to `repr(C, packed)`
Rustc pull update
|
cc @Amanieu, @folkertdev, @sayantn |
|
r? @sayantn |
This comment has been minimized.
This comment has been minimized.
|
The Miri subtree was changed cc @rust-lang/miri |
|
We've supported SSE2 and AVX for a while so regressing this would be unfortunate. Ideally, we'd instead partially revert the PR that removed the LLVM intrinsic shims: 8d597aa. Generally, I find it odd that someone would propose to remove tests without even mentioning this or bringing it up for discussion? The default fix for failing tests should not be to remove the test... |
Sorry. I removed that commit and added a commit to partially revert 8d597aa now. |
|
The Miri part LGTM, thanks! |
|
LGTM too. If I am not mistaken, the beta backport is to be handled in a separate PR, and this should be merged normally, right? |
Yes, according to https://forge.rust-lang.org/release/backporting.html#beta-backporting-in-rust-langrust. |
|
Ok then, let's get the ball rolling @bors r+ |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 1d22b96 (parent) -> 7ecabfa (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7ecabfaaf1a58172cdd71f7661cf6589ddf7928f --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (7ecabfa): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.8%, secondary 6.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 473.382s -> 475.226s (0.39%) |
[beta] backports - Revert "Rollup merge of #149147 - chenyukang:yukang-fix-unused_assignments-macro-gen-147648, r=JonathanBrouwer" #149657 - Don't lint on interior mutable `const` item coming from derefs #150166 - stdarch subtree update #150639 (partial) - Update bors configuration #150308 - Update bors e-mail lookup #150783 - Make verify-channel.sh script compatible with new bors #150759 r? cuviper
Subtree update of
stdarchto rust-lang/stdarch@67cdf84.Created using https://github.com/rust-lang/josh-sync.
r? @ghost