Skip to content

Rollup of 3 pull requests #150351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 6 commits into from
Dec 24, 2025
Merged

Rollup of 3 pull requests #150351

bors merged 6 commits into from
Dec 24, 2025

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 24, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

notgull and others added 6 commits December 22, 2025 19:58
@notgull
bugfix: Fix compile issue in Vita libstd
d2f42b0 
Unfortunately it looks like the Vita libc does not support
the "utimensat" function, which is needed for setting file times.
To fix the build, this commit marks Vita as unsupported for the
function that sets the file times.

Signed-off-by: John Nunley <dev@notgull.net>
@BoxyUwU
Misc cleanups
0e0911b
@bjorn3
Fix some divergences with the cg_clif subtree
a8c9cb5 
For some reason git-subtree incorrectly synced those changes.
@JonathanBrouwer
Rollup merge of rust-lang#150141 - BoxyUwU:borrowck_cleanup_1, r=lcnr
c772ca3 
Misc cleanups from reading some borrowck code

title

r? lcnr
@JonathanBrouwer
Rollup merge of rust-lang#150297 - forkgull:notgull/vita, r=joboet
8e84475 
Fix compile issue in Vita libstd

Unfortunately it looks like the Vita libc does not support
the "utimensat" function, which is needed for setting file times.
To fix the build, this commit marks Vita as unsupported for the
function that sets the file times.
@JonathanBrouwer
Rollup merge of rust-lang#150341 - bjorn3:fix_cg_clif_divergence, r=b…
990783f 
…jorn3

Fix some divergences with the cg_clif subtree

For some reason git-subtree incorrectly synced those changes.

r? `@ghost`

`@rustbot` label +A-codegen +A-cranelift +T-compiler
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 24, 2025
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 24, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Dec 24, 2025

📌 Commit 990783f has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2025
@bors
Copy link
Collaborator

bors commented Dec 24, 2025

⌛ Testing commit 990783f with merge e7d4414...

@bors
Copy link
Collaborator

bors commented Dec 24, 2025

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing e7d4414 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 24, 2025
@bors bors merged commit e7d4414 into rust-lang:main Dec 24, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 24, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 24, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150141 Misc cleanups from reading some borrowck code 59950f81e4328e28263872bd293bb30eb74464fa (link)
#150297 Fix compile issue in Vita libstd 17981e58cf87781a3a211269c5e52aba21dbdb49 (link)
#150341 Fix some divergences with the cg_clif subtree 1585f7fbfb2800feb0a0bacabb97ac8affd29d9b (link)

previous master: 24ac030a79

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 24ac030 (parent) -> e7d4414 (this PR)

Test differences

Show 8 test diffs

8 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e7d44143a12a526488e4f0c0d7ea8e62a4fe9354 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-debug: 4032.0s -> 5445.9s (+35.1%)
  2. dist-aarch64-apple: 5731.6s -> 6956.9s (+21.4%)
  3. pr-check-2: 2486.6s -> 2847.6s (+14.5%)
  4. dist-sparcv9-solaris: 4939.2s -> 5600.9s (+13.4%)
  5. x86_64-msvc-ext1: 7322.8s -> 8239.9s (+12.5%)
  6. armhf-gnu: 4603.3s -> 5150.0s (+11.9%)
  7. dist-powerpc-linux: 4769.5s -> 5308.4s (+11.3%)
  8. x86_64-gnu-llvm-20-2: 5089.8s -> 5654.6s (+11.1%)
  9. dist-x86_64-illumos: 6212.4s -> 6813.4s (+9.7%)
  10. x86_64-gnu-llvm-20: 4135.5s -> 4534.9s (+9.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Dec 24, 2025

Finished benchmarking commit (e7d4414): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.3% [-2.3%, -2.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.1%] 37
Regressions ❌
(secondary)		 0.1% [0.0%, 0.1%] 23
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [0.0%, 0.1%] 37

Bootstrap: 483.817s -> 484.746s (0.19%)
Artifact size: 392.35 MiB -> 392.47 MiB (0.03%)

@github-actions github-actions bot mentioned this pull request Jan 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

7 participants

@JonathanBrouwer @bors @rust-timer @rustbot @notgull @BoxyUwU @bjorn3