Rollup of 4 pull requests

compiler/rustc_codegen_cranelift/example/mini_core.rs

@@ -6,7 +6,6 @@
     extern_types,
     decl_macro,
     rustc_attrs,
-    rustc_private,
     transparent_unions,
     auto_traits,
     freeze_impls,

compiler/rustc_codegen_cranelift/example/mini_core_hello_world.rs

@@ -1,13 +1,4 @@
-#![feature(
-    no_core,
-    lang_items,
-    never_type,
-    linkage,
-    extern_types,
-    thread_local,
-    repr_simd,
-    rustc_private
-)]
+#![feature(no_core, lang_items, never_type, linkage, extern_types, thread_local, repr_simd)]
 #![no_core]
 #![allow(dead_code, non_camel_case_types, internal_features)]
 

compiler/rustc_codegen_cranelift/src/intrinsics/simd.rs

@@ -1005,14 +1005,6 @@ pub(super) fn codegen_simd_intrinsic_call<'tcx>(
             let lane_clif_ty = fx.clif_type(val_lane_ty).unwrap();
             let ret_lane_layout = fx.layout_of(ret_lane_ty);
 
-            let alignment =
-                generic_args[3].expect_const().to_branch()[0].to_leaf().to_simd_alignment();
-
-            let memflags = match alignment {
-                SimdAlign::Unaligned => MemFlags::new().with_notrap(),
-                _ => MemFlags::trusted(),
-            };
-
             for lane_idx in 0..ptr_lane_count {
                 let val_lane = val.value_lane(fx, lane_idx).load_scalar(fx);
                 let ptr_lane = ptr.value_lane(fx, lane_idx).load_scalar(fx);
@@ -1028,7 +1020,7 @@ pub(super) fn codegen_simd_intrinsic_call<'tcx>(
                 fx.bcx.seal_block(if_disabled);
 
                 fx.bcx.switch_to_block(if_enabled);
-                let res = fx.bcx.ins().load(lane_clif_ty, memflags, ptr_lane, 0);
+                let res = fx.bcx.ins().load(lane_clif_ty, MemFlags::trusted(), ptr_lane, 0);
                 fx.bcx.ins().jump(next, &[res.into()]);
 
                 fx.bcx.switch_to_block(if_disabled);

compiler/rustc_codegen_llvm/src/llvm_util.rs

@@ -383,6 +383,7 @@ fn update_target_reliable_float_cfg(sess: &Session, cfg: &mut TargetConfig) {
         // Infinite recursion <https://github.com/llvm/llvm-project/issues/97981>
         (Arch::CSky, _) => false,
         (Arch::Hexagon, _) if major < 21 => false, // (fixed in llvm21)
+        (Arch::LoongArch32 | Arch::LoongArch64, _) if major < 21 => false, // (fixed in llvm21)
         (Arch::PowerPC | Arch::PowerPC64, _) => false,
         (Arch::Sparc | Arch::Sparc64, _) => false,
         (Arch::Wasm32 | Arch::Wasm64, _) => false,

compiler/rustc_codegen_ssa/src/back/link.rs

@@ -103,17 +103,18 @@ pub fn link_binary(
         });
 
         if outputs.outputs.should_link() {
-            let tmpdir = TempDirBuilder::new()
-                .prefix("rustc")
-                .tempdir()
-                .unwrap_or_else(|error| sess.dcx().emit_fatal(errors::CreateTempDir { error }));
-            let path = MaybeTempDir::new(tmpdir, sess.opts.cg.save_temps);
             let output = out_filename(
                 sess,
                 crate_type,
                 outputs,
                 codegen_results.crate_info.local_crate_name,
             );
+            let tmpdir = TempDirBuilder::new()
+                .prefix("rustc")
+                .tempdir_in(output.parent().unwrap_or_else(|| Path::new(".")))
+                .unwrap_or_else(|error| sess.dcx().emit_fatal(errors::CreateTempDir { error }));
+            let path = MaybeTempDir::new(tmpdir, sess.opts.cg.save_temps);
+
             let crate_name = format!("{}", codegen_results.crate_info.local_crate_name);
             let out_filename = output.file_for_writing(
                 outputs,

compiler/rustc_driver_impl/src/lib.rs

@@ -1531,15 +1531,15 @@ fn report_ice(
                         .map(PathBuf::from)
                         .map(|env_var| session_diagnostics::IcePathErrorEnv { env_var }),
                 });
-                dcx.emit_note(session_diagnostics::IceVersion { version, triple: tuple });
                 None
             }
         }
     } else {
-        dcx.emit_note(session_diagnostics::IceVersion { version, triple: tuple });
         None
     };
 
+    dcx.emit_note(session_diagnostics::IceVersion { version, triple: tuple });
+
     if let Some((flags, excluded_cargo_defaults)) = rustc_session::utils::extra_compiler_flags() {
         dcx.emit_note(session_diagnostics::IceFlags { flags: flags.join(" ") });
         if excluded_cargo_defaults {

compiler/rustc_fs_util/src/lib.rs

@@ -1,6 +1,6 @@
 use std::ffi::{CString, OsStr};
 use std::path::{Path, PathBuf, absolute};
-use std::{env, fs, io};
+use std::{fs, io};
 
 use tempfile::TempDir;
 
@@ -139,8 +139,4 @@ impl<'a, 'b> TempDirBuilder<'a, 'b> {
         }
         self.builder.tempdir_in(dir)
     }
-
-    pub fn tempdir(&self) -> io::Result<TempDir> {
-        self.tempdir_in(env::temp_dir())
-    }
 }

tests/run-make/invalid-tmpdir-env-var/rmake.rs → tests/run-make/invalid-tmpdir-no-ice/rmake.rs

@@ -1,9 +1,7 @@
 //@ needs-target-std
 //
 // When the TMP (on Windows) or TMPDIR (on Unix) variable is set to an invalid
-// or non-existing directory, this used to cause an internal compiler error (ICE). After the
-// addition of proper error handling in #28430, this test checks that the expected message is
-// printed.
+// or non-existing directory, this used to cause an internal compiler error (ICE).
 // See https://github.com/rust-lang/rust/issues/14698
 
 use run_make_support::{is_windows, rustc};
@@ -18,5 +16,7 @@ fn main() {
     } else {
         rustc.env("TMPDIR", "fake");
     }
-    rustc.input("foo.rs").run_fail().assert_stderr_contains("couldn't create a temp dir");
+    let result = rustc.input("foo.rs").run_unchecked();
+    // Ensure that rustc doesn't ICE by checking the exit code isn't 101.
+    assert_ne!(result.status().code(), Some(101));
 }