Correct terminology in Clone #150139
Merged
Correct terminology in Clone #150139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
hkBst
approved these changes
Dec 22, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Can you squash this into one commit? |
jhpratt
added
S-waiting-on-author
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
Thanks! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Dec 24, 2025
Rollup merge of #150139 - GKFX:clone-docs, r=jhpratt Correct terminology in Clone I think the current wording around Clone here is confusing: - "Rust does not allow you to reimplement `Copy`" - reimplement isn't a piece of Rust terminology, but as written it sounds like you can't write `impl Copy for X`, which you can. - "you may reimplement `Clone`" - again reimplement isn't really a thing that you do to a trait, the distinction is between manually implementing and deriving. - "you can automatically make anything `Copy` be `Clone` as well" - you don't have a choice about it, so it doesn't really make sense to say you "can ... make" this happen.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Dec 29, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#150016 (stabilize `lazy_get`) - rust-lang/rust#150139 (Correct terminology in Clone) - rust-lang/rust#150238 (mir_build: Classify `TestableCase::Constant` into multiple sub-kinds) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the current wording around Clone here is confusing:
Copy" - reimplement isn't a piece of Rust terminology, but as written it sounds like you can't writeimpl Copy for X, which you can.Clone" - again reimplement isn't really a thing that you do to a trait, the distinction is between manually implementing and deriving.CopybeCloneas well" - you don't have a choice about it, so it doesn't really make sense to say you "can ... make" this happen.