Fudge infer vars in the cause code of Obligation intentionally
#149299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
adwinwhite
force-pushed
the
next-245-ice
branch
from
0e810ef to
c9e720d
Compare
This comment has been minimized.
This comment has been minimized.
adwinwhite
force-pushed
the
next-245-ice
branch
from
c9e720d to
a8e9638
Compare
lcnr
reviewed
Nov 27, 2025
| try_borrowing(cause.derived.parent_trait_pred, &[]) | ||
| // Parent trait predicate may contain regions that's already popped since `cause` | ||
| // in `Obligation` is ignored by folders/visitors. | ||
| // We can erase them since evaluation later doesn't care about regions anyway. |
Contributor
There was a problem hiding this comment.
is that because the BestObligation folder happens inside of a fudge? and would eagerly fudging the cause there as well also avoid this ICE?
Contributor
Author
There was a problem hiding this comment.
It's because of the definition of Obligation. So the region vars in cause is ignored in fudge_inference_if_ok.
Contributor
There was a problem hiding this comment.
yes, but the fudge when computing the best obligation could take (Predicate, Cause) as the return type instead of a full obligation to properly fudge the cause there
lcnr
added
S-waiting-on-author
adwinwhite
force-pushed
the
next-245-ice
branch
from
a8e9638 to
073e537
Compare
adwinwhite
changed the title
Obligation intentionally
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
This fixes #142866 as well 👍 |
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
lcnr
reviewed
Nov 28, 2025
adwinwhite
force-pushed
the
next-245-ice
branch
from
111d965 to
b111aed
Compare
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 1, 2025
Rollup of 9 pull requests Successful merges: - #148690 (Implement `clamp_magnitude` method for primitive floats & signed integers) - #149102 (stabilize maybe_uninit_slice) - #149269 (cmse: do not calculate the layout of a type with infer types) - #149299 (Fudge infer vars in the cause code of `Obligation` intentionally) - #149344 (Don't suggest unwrap for Result in const) - #149358 (fix(parse): Limit frontmatter fences to 255 dashes ) - #149445 (make assoc fn inherit const stability from inherent `const impl` blocks) - #149479 (Fix indent in E0591.md) - #149496 (Fix #148889: Add label rib when visiting delegation body) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 1, 2025
Rollup merge of #149299 - adwinwhite:next-245-ice, r=lcnr Fudge infer vars in the cause code of `Obligation` intentionally Fixes the ICE variant in rust-lang/trait-system-refactor-initiative#245. Fixes #142866. The detailed cause is in the test comments. r? `@lcnr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the ICE variant in rust-lang/trait-system-refactor-initiative#245.
Fixes #142866.
The detailed cause is in the test comments.
r? @lcnr