-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
implement PartialEq<Vec<U>> for [T; N] and &[T; N] #149045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
rustbot has assigned @JonathanBrouwer. Use |
|
How about adding the test mentioned in the issue? fn main() {
let x = vec![1];
let y = [1];
let _ = x == y;
let _ = y == x;
} |
|
r? libs |
|
@bors r+ |
|
📋 This PR cannot be approved because it currently has the following label: |
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
|
@bors r- |
|
Actually this needs an FCP. @rfcbot merge |
|
Error encounted: |
|
@rfcbot merge libs-api |
|
@rustbot ready |
|
@Amanieu Seems like your last rfcbot command didn't work? |
|
@rfcbot merge libs-api |
|
@rfcbot merge libs-api |
|
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Closes #149017
@Centril you're mentioned in the FIXME; do you have thoughts on this?