Skip to content

Conversation

@Qelxiros
Copy link
Contributor

@Qelxiros Qelxiros commented Nov 18, 2025

Closes #149017

@Centril you're mentioned in the FIXME; do you have thoughts on this?

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2025

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@reddevilmidzy
Copy link
Member

How about adding the test mentioned in the issue?

fn main() {
    let x = vec![1];
    let y = [1];
    let _ = x == y;
    let _ = y == x;
}

@JonathanBrouwer
Copy link
Contributor

r? libs

@Mark-Simulacrum Mark-Simulacrum added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2025
@Amanieu
Copy link
Member

Amanieu commented Jan 7, 2026

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 7, 2026

📌 Commit 4274547 has been approved by Amanieu

It is now in the queue for this repository.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-t-libs-api.

@bors
Copy link
Collaborator

bors commented Jan 7, 2026

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 7, 2026
@Amanieu
Copy link
Member

Amanieu commented Jan 7, 2026

@bors r-

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 7, 2026
@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 7, 2026
@Amanieu
Copy link
Member

Amanieu commented Jan 7, 2026

Actually this needs an FCP.

@rfcbot merge

@rust-rfcbot
Copy link
Collaborator

Error encounted:
Provided team `` is invalid

@Amanieu
Copy link
Member

Amanieu commented Jan 7, 2026

@rfcbot merge libs-api

@Qelxiros
Copy link
Contributor Author

@rustbot ready
(I think the labels are weird, but this certainly shouldn't be waiting on me)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 14, 2026
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2026
@theemathas
Copy link
Contributor

@Amanieu Seems like your last rfcbot command didn't work?

@Amanieu
Copy link
Member

Amanieu commented Jan 19, 2026

@rfcbot merge libs-api

@Amanieu Amanieu added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jan 19, 2026
@Amanieu
Copy link
Member

Amanieu commented Jan 19, 2026

@rfcbot merge libs-api

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Jan 19, 2026

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 19, 2026
@rust-rfcbot
Copy link
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

@Amanieu Amanieu added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api labels Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing impl PartialEq<Vec<T>> for [T; N]

9 participants