Add another *ExprWithBlock* test for try blocks
#148968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
Open
16 tasks
Kivooeo
reviewed
Nov 15, 2025
| @@ -0,0 +1,24 @@ | |||
| //@ check-fail | |||
| //@ edition: 2018 | |||
Member
There was a problem hiding this comment.
A bit wonder about why edition 2018
(I know that most/all try block tests are using this edition, but I'm unsure, can we maybe update edition?)
Member
Author
There was a problem hiding this comment.
Because try isn't a keyword in 2015.
(I didn't actually think about which edition, just copied an existing try block test.)
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 15, 2025
…Kivooeo Add another *ExprWithBlock* test for `try` blocks Looking to address this open item from rust-lang#31436 > Add a test confirming that it's an `ExprWithBlock`, so works in a match arm without a comma It turns out that rust-lang#120540 addressed that one, but it made me think of this other case that probably ought to have some kind of test as well.
bors
added a commit
that referenced
this pull request
Nov 16, 2025
Rollup of 10 pull requests Successful merges: - #148416 (`vec_recycle`: implementation) - #148522 (Micro-optimize rustdoc search index parsing) - #148827 (Stabilize vec_into_raw_parts) - #148832 (Bump library dependencies) - #148836 (tweak primitive reference docs) - #148859 (Fix overflow-checks test for RISC-V target) - #148886 (Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS) - #148956 (re-enable wasm abi test) - #148963 (runtest.rs: remove redundant check) - #148968 (Add another *ExprWithBlock* test for `try` blocks) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Nov 16, 2025
Rollup of 11 pull requests Successful merges: - #148416 (`vec_recycle`: implementation) - #148522 (Micro-optimize rustdoc search index parsing) - #148827 (Stabilize vec_into_raw_parts) - #148832 (Bump library dependencies) - #148836 (tweak primitive reference docs) - #148859 (Fix overflow-checks test for RISC-V target) - #148886 (Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS) - #148956 (re-enable wasm abi test) - #148963 (runtest.rs: remove redundant check) - #148968 (Add another *ExprWithBlock* test for `try` blocks) - #148984 (chore: Update annotate-snippets to 0.12.9) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 16, 2025
Rollup merge of #148968 - scottmcm:try-block-brace-tests, r=Kivooeo Add another *ExprWithBlock* test for `try` blocks Looking to address this open item from #31436 > Add a test confirming that it's an `ExprWithBlock`, so works in a match arm without a comma It turns out that #120540 addressed that one, but it made me think of this other case that probably ought to have some kind of test as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to address this open item from #31436
It turns out that #120540 addressed that one, but it made me think of this other case that probably ought to have some kind of test as well.