Constify DropGuard::dismiss and trait impls
#148755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
Member
|
r? libs-api |
rustbot
added
the
T-libs-api
rustbot
added
S-blocked
nxsaken
force-pushed
the
const_drop_guard
branch
from
3564847 to
a86a557
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
rustbot
removed
the
S-blocked
Member
|
#148589 Was just approved and renames |
Collaborator
|
☔ The latest upstream changes (presumably #149387) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
nxsaken
force-pushed
the
const_drop_guard
branch
from
a86a557 to
b273af3
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
nxsaken
changed the title
DropGuard::into_inner and trait implsDropGuard::dismiss and trait impls
nxsaken
force-pushed
the
const_drop_guard
branch
from
b273af3 to
e163707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
drop_guard(#144426),const_convert(#143773),const_drop_guard(no tracking issue yet)Constifies
DropGuard::dismissand trait impls.I reused
const_convert(#143773) for theDeref*impls.