resolve: Do not consider traits from ambiguous imports to be in scope #147995
Conversation
rustbot
added
S-waiting-on-review
|
@bors try |
This comment has been minimized.
This comment has been minimized.
resolve: Do not consider traits from ambiguous imports to be in scope
petrochenkov
added
S-waiting-on-crater
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
| impl Trait for u8 {} | ||
| } | ||
|
|
||
| fn test1() { |
There was a problem hiding this comment.
Nit: Could you add #[rustfmt::skip] to this and test2, I'd be worried about the test no longer testing the right thing if someone decided to reformat these.
| let mut collected_traits = Vec::new(); | ||
| self.for_each_child(resolver, |r, name, ns, binding| { | ||
| if ns != TypeNS { | ||
| if ns != TypeNS || binding.is_ambiguity_recursive() { |
There was a problem hiding this comment.
I'm not too familiar with rustc_resolve - are there be other instances of for_each_child that would benefit from a similar is_ambiguity_recursive check?
There was a problem hiding this comment.
Not at the moment, #57199 describes the logic behind these checks, this was the one place missing.
There was a problem hiding this comment.
we do have for_each_child_mut?
There was a problem hiding this comment.
we do have
for_each_child_mut?
Its only use in process_macro_use_imports doesn't need this check either.
5 participants
One of unblocking steps for #145108.
Fixes #147992.